Code Review for sandbox

Prepared by: Jan Lahoda (jlahoda) on Thu Jun 18 03:06:24 PDT 2015
Workspace:/scratch/jlahoda/hudson-standalone/.hudson/jobs/jline-patches/workspace/sandbox
Summary of changes: 871 lines changed: 497 ins; 89 del; 285 mod; 13300 unchg
Patch of changes: sandbox.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

4 lines changed: 4 ins; 0 del; 0 mod; 574 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Images.gmk

1 line changed: 0 ins; 0 del; 1 mod; 523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules.xml

22 lines changed: 22 ins; 0 del; 0 mod; 1897 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/src/classes/build/tools/module/ext.modules

1 line changed: 1 ins; 0 del; 0 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/NoInterruptUnixTerminal.java

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/Terminal.java

1 line changed: 0 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/TerminalFactory.java

8 lines changed: 1 ins; 1 del; 6 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/TerminalSupport.java

4 lines changed: 0 ins; 0 del; 4 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/UnixTerminal.java

4 lines changed: 0 ins; 0 del; 4 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/UnsupportedTerminal.java

1 line changed: 0 ins; 0 del; 1 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/WindowsTerminal.java

233 lines changed: 169 ins; 7 del; 57 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/ConsoleKeys.java

3 lines changed: 0 ins; 0 del; 3 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/ConsoleReader.java

42 lines changed: 7 ins; 0 del; 35 mod; 3939 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/CursorBuffer.java

4 lines changed: 0 ins; 0 del; 4 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/KeyMap.java

27 lines changed: 0 ins; 0 del; 27 mod; 551 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/KillRing.java

1 line changed: 0 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/Operation.java

1 line changed: 0 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/UserInterruptException.java

3 lines changed: 2 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/AggregateCompleter.java

2 lines changed: 0 ins; 0 del; 2 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/ArgumentCompleter.java

3 lines changed: 0 ins; 0 del; 3 mod; 458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/CandidateListCompletionHandler.java

3 lines changed: 0 ins; 0 del; 3 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/Completer.java

1 line changed: 0 ins; 0 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/CompletionHandler.java

2 lines changed: 0 ins; 0 del; 2 mod; 24 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/EnumCompleter.java

3 lines changed: 0 ins; 0 del; 3 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/FileNameCompleter.java

3 lines changed: 0 ins; 0 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/NullCompleter.java

1 line changed: 0 ins; 0 del; 1 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/StringsCompleter.java

2 lines changed: 0 ins; 0 del; 2 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/completer/package-info.java

1 line changed: 0 ins; 0 del; 1 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/history/FileHistory.java

4 lines changed: 0 ins; 1 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/history/History.java

2 lines changed: 0 ins; 0 del; 2 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/history/MemoryHistory.java

2 lines changed: 0 ins; 0 del; 2 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/history/PersistentHistory.java

1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/history/package-info.java

1 line changed: 0 ins; 0 del; 1 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/internal/ConsoleReaderInputStream.java

25 lines changed: 0 ins; 0 del; 25 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/internal/ConsoleRunner.java

19 lines changed: 0 ins; 0 del; 19 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/console/package-info.java

1 line changed: 0 ins; 0 del; 1 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/Configuration.java

2 lines changed: 0 ins; 0 del; 2 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/InputStreamReader.java

12 lines changed: 0 ins; 0 del; 12 mod; 325 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/Log.java

2 lines changed: 0 ins; 0 del; 2 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/NonBlockingInputStream.java

35 lines changed: 0 ins; 0 del; 35 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/Nullable.java

1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/Preconditions.java

1 line changed: 0 ins; 0 del; 1 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/ShutdownHooks.java

2 lines changed: 0 ins; 0 del; 2 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/TerminalLineSettings.java

4 lines changed: 0 ins; 0 del; 4 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/TestAccessible.java

1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/Urls.java

1 line changed: 0 ins; 0 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/internal/package-info.java

1 line changed: 0 ins; 0 del; 1 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jline/share/classes/jdk/internal/jline/package-info.java

1 line changed: 0 ins; 0 del; 1 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/TEST.groups

4 lines changed: 4 ins; 0 del; 0 mod; 746 unchg

------ ------ ------ ------ --- New Patch Raw jdk/make/lib/Lib-jdk.jline.gmk

60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/jdk.jline/windows/native/libjline/WindowsTerminal.cpp

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/jdk/internal/jline/KeyConversionTest.java

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw jdk/test/jdk/internal/jline/console/StripAnsiTest.java

56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- jdk/src/jdk.jline/share/classes/jdk/internal/jline/AnsiWindowsTerminal.java

80 lines changed: 0 ins; 80 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/jlahoda/hudson-standalone/.hudson/jobs/jline-patches/workspace/webrev/webrev.ksh (vers 25.10-hg+openjdk.java.net).