Code Review for jdk

Prepared by:alanb on Fri Jan 11 14:57:52 GMT 2013
Workspace:/u/alanb/ws/tl/jdk
Summary of changes: 581 lines changed: 327 ins; 13 del; 241 mod; 9839 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/ProblemList.txt

3 lines changed: 3 ins; 0 del; 0 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh

10 lines changed: 4 ins; 4 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/com/sun/management/UnixOperatingSystemMXBean/GetMaxFileDescriptorCount.sh

10 lines changed: 4 ins; 4 del; 2 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh

10 lines changed: 3 ins; 4 del; 3 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/FileOutputStream/FileOpen.sh

4 lines changed: 2 ins; 0 del; 2 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/class/run.sh

20 lines changed: 4 ins; 0 del; 16 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/evolution/RenamePackage/run.sh

11 lines changed: 7 ins; 0 del; 4 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/maskSyntheticModifier/run.sh

7 lines changed: 4 ins; 0 del; 3 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/packageAccess/run.sh

10 lines changed: 5 ins; 0 del; 5 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/resolveClass/consTest/run.sh

10 lines changed: 5 ins; 0 del; 5 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/resolveClass/deserializeButton/run.sh

9 lines changed: 4 ins; 0 del; 5 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/superclassDataLoss/run.sh

11 lines changed: 6 ins; 0 del; 5 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/io/Serializable/unnamedPackageSwitch/run.sh

8 lines changed: 5 ins; 0 del; 3 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Class/getEnclosingClass/build.sh

3 lines changed: 1 ins; 0 del; 2 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/ClassLoader/Assert.sh

5 lines changed: 4 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/ClassLoader/deadlock/TestCrossDelegate.sh

6 lines changed: 4 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh

7 lines changed: 5 ins; 0 del; 2 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/System/MacJNUEncoding/MacJNUEncoding.sh

7 lines changed: 5 ins; 0 del; 2 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Thread/UncaughtExceptions.sh

2 lines changed: 0 ins; 0 del; 2 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/annotation/loaderLeak/LoaderLeak.sh

6 lines changed: 4 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/AppendToBootstrapClassPathSetUp.sh

7 lines changed: 6 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/AppendToClassPathSetUp.sh

8 lines changed: 6 ins; 0 del; 2 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/BootClassPath/BootClassPathTest.sh

18 lines changed: 9 ins; 0 del; 9 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/MakeJAR.sh

11 lines changed: 6 ins; 1 del; 4 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/MakeJAR2.sh

12 lines changed: 6 ins; 0 del; 6 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/MakeJAR3.sh

10 lines changed: 6 ins; 0 del; 4 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/MakeJAR4.sh

10 lines changed: 6 ins; 0 del; 4 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/ManifestTest.sh

11 lines changed: 6 ins; 0 del; 5 mod; 491 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/ParallelTransformerLoader.sh

10 lines changed: 6 ins; 0 del; 4 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/NoPremainAgent.sh

7 lines changed: 6 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/PremainClassTest.sh

8 lines changed: 6 ins; 0 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh

7 lines changed: 6 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineBigClass.sh

7 lines changed: 6 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineClassWithNativeMethod.sh

7 lines changed: 6 ins; 0 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineMethodAddInvoke.sh

9 lines changed: 6 ins; 0 del; 3 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineSetUp.sh

9 lines changed: 6 ins; 0 del; 3 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RetransformBigClass.sh

7 lines changed: 6 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh

10 lines changed: 5 ins; 0 del; 5 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh

3 lines changed: 1 ins; 0 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh

8 lines changed: 6 ins; 0 del; 2 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh

8 lines changed: 0 ins; 0 del; 8 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/Authenticator/B4933582.sh

2 lines changed: 1 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URL/B5086147.sh

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URL/runconstructor.sh

2 lines changed: 1 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URLClassLoader/B5077773.sh

2 lines changed: 1 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URLClassLoader/closetest/build.sh

12 lines changed: 5 ins; 0 del; 7 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URLClassLoader/getresourceasstream/test.sh

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URLClassLoader/sealing/checksealed.sh

3 lines changed: 2 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URLConnection/6212146/test.sh

1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/net/URLConnection/UNCTest.sh

1 line changed: 0 ins; 0 del; 1 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/charset/spi/basic.sh

3 lines changed: 1 ins; 0 del; 2 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/registry/readTest/readTest.sh

3 lines changed: 0 ins; 0 del; 3 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh

6 lines changed: 4 ins; 0 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/Security/ClassLoaderDeadlock/Deadlock2.sh

6 lines changed: 4 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/Security/signedfirst/Dyn.sh

5 lines changed: 4 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/Security/signedfirst/Static.sh

5 lines changed: 4 ins; 0 del; 1 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/cert/CertificateFactory/slowstream.sh

5 lines changed: 4 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Formatter/Basic.sh

3 lines changed: 1 ins; 0 del; 2 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Locale/LocaleProviders.sh

7 lines changed: 5 ins; 0 del; 2 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/PluggableLocale/ExecTest.sh

6 lines changed: 5 ins; 0 del; 1 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/ServiceLoader/basic.sh

3 lines changed: 1 ins; 0 del; 2 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh

8 lines changed: 4 ins; 0 del; 4 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/prefs/PrefsSpi.sh

7 lines changed: 3 ins; 0 del; 4 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/javax/crypto/SecretKeyFactory/FailOverTest.sh

6 lines changed: 5 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/javax/script/CommonSetup.sh

7 lines changed: 5 ins; 0 del; 2 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/javax/script/ProviderTest.sh

1 line changed: 0 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/javax/security/auth/Subject/doAs/Test.sh

2 lines changed: 1 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/security/java.policy/Ext_AllPolicy.sh

4 lines changed: 3 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.sh

1 line changed: 0 ins; 0 del; 1 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.sh

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/management/jmxremote/startstop/JMXStartStopTest.sh

6 lines changed: 2 ins; 0 del; 4 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/net/www/MarkResetTest.sh

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/net/www/http/HttpClient/RetryPost.sh

1 line changed: 0 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/net/www/protocol/jar/B5105410.sh

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/net/www/protocol/jar/jarbug/run.sh

4 lines changed: 0 ins; 0 del; 4 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/krb5/config/dns.sh

5 lines changed: 3 ins; 0 del; 2 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/krb5/runNameEquals.sh

5 lines changed: 4 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/mscapi/IsSunMSCAPIAvailable.sh

1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/KeyStore/Basic.sh

5 lines changed: 4 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/KeyStore/ClientAuth.sh

5 lines changed: 4 ins; 0 del; 1 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/KeyStore/Solaris.sh

5 lines changed: 4 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/Provider/ConfigQuotedString.sh

5 lines changed: 4 ins; 0 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/pkcs11/Provider/Login.sh

5 lines changed: 4 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.sh

9 lines changed: 6 ins; 0 del; 3 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/provider/PolicyFile/getinstance/getinstance.sh

9 lines changed: 4 ins; 0 del; 5 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh

2 lines changed: 1 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NotifyHandshakeTest.sh

7 lines changed: 4 ins; 0 del; 3 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.sh

4 lines changed: 2 ins; 0 del; 2 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxyWithAuth.sh

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/keytool/autotest.sh

4 lines changed: 3 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/keytool/printssl.sh

4 lines changed: 3 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/keytool/readjar.sh

6 lines changed: 1 ins; 0 del; 5 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/keytool/standard.sh

2 lines changed: 1 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/util/Oid/S11N.sh

4 lines changed: 3 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/validator/certreplace.sh

3 lines changed: 1 ins; 0 del; 2 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/validator/samedn.sh

3 lines changed: 1 ins; 0 del; 2 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/ClassPathWildCard.sh

8 lines changed: 4 ins; 0 del; 4 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/MultipleJRE.sh

5 lines changed: 4 ins; 0 del; 1 mod; 470 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 23.18-hg).