Code Review for jdk

Prepared by:henryjen on Wed Jul 10 14:12:01 PDT 2013
Workspace:/home/hjen/ws/tl-work/jdk
Compare against: /home/hjen/ws/tl/jdk
Compare against version:-2
Summary of changes: 2098 lines changed: 1572 ins; 367 del; 159 mod; 13172 unchg
Patch of changes: jdk.patch
Bug id: JDK-8017513 : Support for closeable streams - Java Bug System
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/nio/file/Files.java

rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
176 lines changed: 67 ins; 39 del; 70 mod; 3410 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/AbstractPipeline.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
34 lines changed: 26 ins; 0 del; 8 mod; 678 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/BaseStream.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
17 lines changed: 16 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/DoublePipeline.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
5 lines changed: 1 ins; 0 del; 4 mod; 603 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/DoubleStream.java

rev 7627 : 8015315: Stream.concat methods
Reviewed-by: psandoz
Contributed-by: brian.goetz@oracle.com, henry.jen@oracle.com
rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7631 : 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces
Reviewed-by: psandoz
Contributed-by: brian goetz <brian.goetz@oracle.com>
rev 7632 : 8015318: Extend Collector with 'finish' operation
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 824 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/IntPipeline.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
5 lines changed: 1 ins; 0 del; 4 mod; 638 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/IntStream.java

rev 7627 : 8015315: Stream.concat methods
Reviewed-by: psandoz
Contributed-by: brian.goetz@oracle.com, henry.jen@oracle.com
rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7631 : 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces
Reviewed-by: psandoz
Contributed-by: brian goetz <brian.goetz@oracle.com>
rev 7632 : 8015318: Extend Collector with 'finish' operation
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 878 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/LongPipeline.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
5 lines changed: 1 ins; 0 del; 4 mod; 618 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/LongStream.java

rev 7627 : 8015315: Stream.concat methods
Reviewed-by: psandoz
Contributed-by: brian.goetz@oracle.com, henry.jen@oracle.com
rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7631 : 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces
Reviewed-by: psandoz
Contributed-by: brian goetz <brian.goetz@oracle.com>
rev 7632 : 8015318: Extend Collector with 'finish' operation
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 884 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/ReferencePipeline.java

rev 7632 : 8015318: Extend Collector with 'finish' operation
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
20 lines changed: 4 ins; 0 del; 16 mod; 649 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/Stream.java

rev 7627 : 8015315: Stream.concat methods
Reviewed-by: psandoz
Contributed-by: brian.goetz@oracle.com, henry.jen@oracle.com
rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7631 : 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces
Reviewed-by: psandoz
Contributed-by: brian goetz <brian.goetz@oracle.com>
rev 7632 : 8015318: Extend Collector with 'finish' operation
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 969 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/util/stream/Streams.java

rev 7627 : 8015315: Stream.concat methods
Reviewed-by: psandoz
Contributed-by: brian.goetz@oracle.com, henry.jen@oracle.com
rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7631 : 8020062: Nest StreamBuilder interfaces inside relevant Stream interfaces
Reviewed-by: psandoz
Contributed-by: brian goetz <brian.goetz@oracle.com>
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
58 lines changed: 58 ins; 0 del; 0 mod; 813 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/nio/file/Files/StreamTest.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
42 lines changed: 2 ins; 0 del; 40 mod; 621 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/util/Spliterator/SpliteratorCollisions.java

rev 7629 : 8015320: Pull spliterator() up from Collection to Iterable
Reviewed-by: psandoz
Contributed-by: brian.goetz@oracle.com
* * *
Promote part of implNote to implSpec
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
1 line changed: 0 ins; 1 del; 0 mod; 705 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java

rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java

rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java

rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java

rev 7630 : 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method
Reviewed-by: henryjen
rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
2 lines changed: 1 ins; 0 del; 1 mod; 224 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/share/classes/java/util/MayHoldCloseableResource.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/nio/Files/FilesLambdaTest.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
336 lines changed: 336 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamCloseTest.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/sqeutil/LambdaUtilities.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
674 lines changed: 674 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/sqeutil/StringUtilities.java

rev 7633 : 8017513: Support for closeable streams
Reviewed-by:
Contributed-by: brian.goetz@oracle.com
132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/share/classes/java/util/stream/CloseableStream.java

57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/share/classes/java/util/stream/DelegatingStream.java

270 lines changed: 0 ins; 270 del; 0 mod; 0 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).