Code Review for open

Prepared by:iveresov on Tue Dec 11 11:13:48 PST 2018
Workspace:/Users/iggy/work/jdk-update-graal/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Summary of changes: 1407 lines changed: 731 ins; 363 del; 313 mod; 18482 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTCompiledClass.java

2 lines changed: 0 ins; 1 del; 1 mod; 470 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.replacements/src/org/graalvm/compiler/api/replacements/SnippetReflectionProvider.java

23 lines changed: 7 ins; 14 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/Fields.java

1 line changed: 0 ins; 0 del; 1 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/spi/JavaConstantFieldProvider.java

22 lines changed: 19 ins; 0 del; 3 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64.test/src/org/graalvm/compiler/hotspot/amd64/test/StubAVXTest.java

14 lines changed: 10 ins; 1 del; 3 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java

1 line changed: 1 ins; 0 del; 0 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java

2 lines changed: 1 ins; 1 del; 0 mod; 602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/LoadJavaMirrorWithKlassTest.java

5 lines changed: 5 ins; 0 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierAdditionTest.java

23 lines changed: 17 ins; 2 del; 4 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigBase.java

4 lines changed: 4 ins; 0 del; 0 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotCompiledCodeBuilder.java

5 lines changed: 0 ins; 2 del; 3 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java

5 lines changed: 5 ins; 0 del; 0 mod; 607 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotHostBackend.java

1 line changed: 1 ins; 0 del; 0 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotReplacementsImpl.java

18 lines changed: 15 ins; 1 del; 2 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java

32 lines changed: 22 ins; 6 del; 4 mod; 776 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java

17 lines changed: 1 ins; 14 del; 2 mod; 515 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotLoweringProvider.java

6 lines changed: 6 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotProviders.java

51 lines changed: 51 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotSnippetReflectionProvider.java

14 lines changed: 3 ins; 9 del; 2 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotWordOperationPlugin.java

1 line changed: 0 ins; 0 del; 1 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/InitializeKlassStubCall.java

2 lines changed: 1 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/ResolveConstantStubCall.java

3 lines changed: 1 ins; 0 del; 2 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/ResolveMethodAndLoadCountersStubCall.java

2 lines changed: 1 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/OnStackReplacementPhase.java

2 lines changed: 1 ins; 1 del; 0 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/AESCryptSubstitutions.java

24 lines changed: 4 ins; 9 del; 11 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/CipherBlockChainingSubstitutions.java

70 lines changed: 14 ins; 23 del; 33 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java

119 lines changed: 78 ins; 25 del; 16 mod; 788 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/MonitorSnippets.java

65 lines changed: 6 ins; 5 del; 54 mod; 808 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/NewObjectSnippets.java

71 lines changed: 20 ins; 9 del; 42 mod; 783 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/ObjectCloneNode.java

10 lines changed: 5 ins; 2 del; 3 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/ObjectCloneSnippets.java

25 lines changed: 5 ins; 5 del; 15 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA2Substitutions.java

29 lines changed: 8 ins; 18 del; 3 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA5Substitutions.java

26 lines changed: 6 ins; 18 del; 2 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHASubstitutions.java

26 lines changed: 6 ins; 18 del; 2 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/StringToBytesSnippets.java

11 lines changed: 3 ins; 6 del; 2 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/UnsafeLoadSnippets.java

2 lines changed: 1 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/WriteBarrierSnippets.java

3 lines changed: 1 ins; 0 del; 2 mod; 618 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/profiling/ProbabilisticProfileSnippets.java

10 lines changed: 3 ins; 0 del; 7 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/profiling/ProfileSnippets.java

10 lines changed: 3 ins; 0 del; 7 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/CreateExceptionStub.java

2 lines changed: 1 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/ExceptionHandlerStub.java

9 lines changed: 0 ins; 5 del; 4 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/ForeignCallStub.java

40 lines changed: 31 ins; 1 del; 8 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/SnippetStub.java

49 lines changed: 8 ins; 36 del; 5 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/StubUtil.java

64 lines changed: 0 ins; 64 del; 0 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/UnwindExceptionToCallerStub.java

7 lines changed: 1 ins; 1 del; 5 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/VerifyOopStub.java

1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/EncodedGraph.java

16 lines changed: 13 ins; 0 del; 3 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/PiNode.java

8 lines changed: 2 ins; 2 del; 4 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/RawStoreNode.java

3 lines changed: 3 ins; 0 del; 0 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/InstanceOfNode.java

16 lines changed: 16 ins; 0 del; 0 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/DelegatingReplacements.java

8 lines changed: 6 ins; 0 del; 2 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/Replacements.java

16 lines changed: 15 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/util/Providers.java

8 lines changed: 8 ins; 0 del; 0 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.processor/src/org/graalvm/compiler/replacements/processor/InjectedDependencies.java

3 lines changed: 3 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.processor/src/org/graalvm/compiler/replacements/processor/NodeIntrinsicHandler.java

9 lines changed: 9 ins; 0 del; 0 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/ReplacementsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/SnippetsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringCompareToTest.java

1 line changed: 1 ins; 0 del; 0 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/GraphKit.java

6 lines changed: 3 ins; 0 del; 3 mod; 629 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/NodeIntrinsificationProvider.java

2 lines changed: 2 ins; 0 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java

27 lines changed: 26 ins; 0 del; 1 mod; 1299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ReplacementsImpl.java

39 lines changed: 20 ins; 1 del; 18 mod; 509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ReplacementsUtil.java

12 lines changed: 12 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetTemplate.java

43 lines changed: 21 ins; 6 del; 16 mod; 1744 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopySnippets.java

8 lines changed: 0 ins; 4 del; 4 mod; 583 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/AssertionNode.java

12 lines changed: 9 ins; 0 del; 3 mod; 113 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/ForeignCallSnippets.java

144 lines changed: 144 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/SuppressFBWarnings.java

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/UnsafeAccess.java

53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

This code review page was prepared using /Users/iggy/bin/webrev (vers 25.17-hg+openjdk.java.net).