Code Review for jdkhs-event

Prepared by:jcbeyler on Wed Mar 28 08:19:12 PDT 2018
Workspace:/usr/local/google/home/jcbeyler/mercurial/jdkhs-event
Compare against: http://hg.openjdk.java.net/jdk/hs
Compare against version:49263
Summary of changes: 2735 lines changed: 2646 ins; 16 del; 73 mod; 105393 unchg
Changeset: jdkhs-event.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/test/JtregNativeHotspot.gmk

rev 49264 : [mq]: event-only
1 line changed: 1 ins; 0 del; 0 mod; 175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

rev 49264 : [mq]: event-only
2 lines changed: 0 ins; 0 del; 2 mod; 5666 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/macroAssembler_arm.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 3264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/arm/templateTable_arm.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 5024 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/macroAssembler_ppc.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 5360 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/ppc/templateTable_ppc_64.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 4273 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/macroAssembler_s390.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 7470 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/s390/templateTable_s390.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 4368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/macroAssembler_sparc.cpp

rev 49264 : [mq]: event-only
2 lines changed: 0 ins; 0 del; 2 mod; 5057 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/templateTable_sparc.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 3725 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 49264 : [mq]: event-only
2 lines changed: 0 ins; 0 del; 2 mod; 11261 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/templateTable_x86.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 4575 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 49264 : [mq]: event-only
20 lines changed: 19 ins; 0 del; 1 mod; 586 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.inline.hpp

rev 49264 : [mq]: event-only
6 lines changed: 4 ins; 0 del; 2 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp

rev 49264 : [mq]: event-only
rev 49268 : [mq]: event6
55 lines changed: 50 ins; 0 del; 5 mod; 430 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp

rev 49264 : [mq]: event-only
rev 49268 : [mq]: event6
24 lines changed: 16 ins; 1 del; 7 mod; 258 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/threadLocalAllocBuffer.inline.hpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/interpreterRuntime.cpp

rev 49267 : [mq]: event5
4 lines changed: 4 ins; 0 del; 0 mod; 1522 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 981 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/macro.cpp

rev 49264 : [mq]: event-only
2 lines changed: 0 ins; 0 del; 2 mod; 2802 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/runtime.cpp

rev 49264 : [mq]: event-only
6 lines changed: 6 ins; 0 del; 0 mod; 1663 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmti.xml

rev 49264 : [mq]: event-only
rev 49265 : [mq]: event3
rev 49266 : [mq]: event4
rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
rev 49269 : [mq]: event7
116 lines changed: 112 ins; 0 del; 4 mod; 14829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEnv.cpp

rev 49264 : [mq]: event-only
rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
rev 49269 : [mq]: event7
17 lines changed: 17 ins; 0 del; 0 mod; 3711 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEventController.cpp

rev 49264 : [mq]: event-only
2 lines changed: 2 ins; 0 del; 0 mod; 1077 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.cpp

rev 49264 : [mq]: event-only
128 lines changed: 95 ins; 9 del; 24 mod; 2833 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiExport.hpp

rev 49264 : [mq]: event-only
57 lines changed: 44 ins; 5 del; 8 mod; 560 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiManageCapabilities.cpp

rev 49264 : [mq]: event-only
rev 49265 : [mq]: event3
rev 49268 : [mq]: event6
3 lines changed: 3 ins; 0 del; 0 mod; 451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.cpp

rev 49264 : [mq]: event-only
1 line changed: 1 ins; 0 del; 0 mod; 401 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiThreadState.hpp

rev 49264 : [mq]: event-only
8 lines changed: 8 ins; 0 del; 0 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.cpp

rev 49267 : [mq]: event5
5 lines changed: 5 ins; 0 del; 0 mod; 330 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.hpp

rev 49267 : [mq]: event5
1 line changed: 1 ins; 0 del; 0 mod; 367 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.cpp

rev 49264 : [mq]: event-only
3 lines changed: 2 ins; 1 del; 0 mod; 4977 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.hpp

rev 49264 : [mq]: event-only
6 lines changed: 4 ins; 0 del; 2 mod; 2227 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vmStructs.cpp

rev 49264 : [mq]: event-only
1 line changed: 0 ins; 0 del; 1 mod; 3491 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java

rev 49269 : [mq]: event7
1 line changed: 0 ins; 0 del; 1 mod; 840 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.cpp

rev 49264 : [mq]: event-only
rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/threadHeapSampler.hpp

rev 49264 : [mq]: event-only
rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/Frame.java

rev 49264 : [mq]: event-only
rev 49267 : [mq]: event5
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java

rev 49264 : [mq]: event-only
rev 49266 : [mq]: event4
rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
169 lines changed: 169 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorArrayAllSampledTest.java

rev 49268 : [mq]: event6
rev 49269 : [mq]: event7
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorEventOnOffTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java

rev 49267 : [mq]: event5
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCParallelTest.java

rev 49267 : [mq]: event5
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCSerialTest.java

rev 49267 : [mq]: event5
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorIllegalArgumentTest.java

rev 49269 : [mq]: event7
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterArrayTest.java

rev 49267 : [mq]: event5
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterObjectTest.java

rev 49267 : [mq]: event5
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorNoCapabilityTest.java

rev 49264 : [mq]: event-only
rev 49269 : [mq]: event7
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
rev 49269 : [mq]: event7
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
rev 49269 : [mq]: event7
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatSimpleTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTest.java

rev 49264 : [mq]: event-only
rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadOnOffTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadTest.java

rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
rev 49269 : [mq]: event7
104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitor.c

rev 49264 : [mq]: event-only
rev 49266 : [mq]: event4
rev 49267 : [mq]: event5
rev 49268 : [mq]: event6
rev 49269 : [mq]: event7
754 lines changed: 754 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ./webrev.ksh (vers 25.16-hg+openjdk.java.net).