Code Review for open

Prepared by:kbarrett on Tue Jul 10 15:43:06 EDT 2018
Workspace:/home/kab/sandboxes/readdir/jdk/open
Compare against version:qparent
Summary of changes: 255 lines changed: 17 ins; 201 del; 37 mod; 40835 unchg
Patch of changes: open.patch
Bug id: JDK-8202353 : os::readdir should use readdir instead of readdir_r
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/aix/os_aix.cpp

rev 50955 : [mq]: readdir
2 lines changed: 0 ins; 1 del; 1 mod; 4373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/aix/os_aix.inline.hpp

rev 50955 : [mq]: readdir
28 lines changed: 0 ins; 28 del; 0 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/aix/os_perf_aix.cpp

rev 50955 : [mq]: readdir
13 lines changed: 0 ins; 10 del; 3 mod; 1076 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/aix/perfMemory_aix.cpp

rev 50955 : [mq]: readdir
11 lines changed: 0 ins; 8 del; 3 mod; 1351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

rev 50955 : [mq]: readdir
2 lines changed: 0 ins; 1 del; 1 mod; 3902 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.inline.hpp

rev 50955 : [mq]: readdir
33 lines changed: 0 ins; 33 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/perfMemory_bsd.cpp

rev 50955 : [mq]: readdir
11 lines changed: 0 ins; 8 del; 3 mod; 1257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

rev 50955 : [mq]: readdir
2 lines changed: 0 ins; 1 del; 1 mod; 6157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.inline.hpp

rev 50955 : [mq]: readdir
22 lines changed: 0 ins; 22 del; 0 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_perf_linux.cpp

rev 50955 : [mq]: readdir
18 lines changed: 0 ins; 13 del; 5 mod; 1125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/perfMemory_linux.cpp

rev 50955 : [mq]: readdir
11 lines changed: 0 ins; 8 del; 3 mod; 1346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/posix/os_posix.cpp

rev 50955 : [mq]: readdir
16 lines changed: 16 ins; 0 del; 0 mod; 2111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_perf_solaris.cpp

rev 50955 : [mq]: readdir
15 lines changed: 1 ins; 9 del; 5 mod; 827 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.cpp

rev 50955 : [mq]: readdir
3 lines changed: 0 ins; 2 del; 1 mod; 5443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.inline.hpp

rev 50955 : [mq]: readdir
28 lines changed: 0 ins; 28 del; 0 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/perfMemory_solaris.cpp

rev 50955 : [mq]: readdir
11 lines changed: 0 ins; 8 del; 3 mod; 1291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

rev 50955 : [mq]: readdir
4 lines changed: 0 ins; 1 del; 3 mod; 5662 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.inline.hpp

rev 50955 : [mq]: readdir
8 lines changed: 0 ins; 8 del; 0 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/perfMemory_windows.cpp

rev 50955 : [mq]: readdir
9 lines changed: 0 ins; 6 del; 3 mod; 1840 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp

rev 50955 : [mq]: readdir
5 lines changed: 0 ins; 4 del; 1 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.hpp

rev 50955 : [mq]: readdir
2 lines changed: 0 ins; 1 del; 1 mod; 1035 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/ProblemList.txt

rev 50955 : [mq]: readdir
1 line changed: 0 ins; 1 del; 0 mod; 883 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).