Code Review for open

Prepared by:kvn on Fri May 31 08:55:27 PDT 2019
Workspace:/Users/kvn/work/hotspot/c2_gk/jdk_test/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Summary of changes: 601 lines changed: 393 ins; 19 del; 189 mod; 41517 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciMethod.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1516 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compileBroker.cpp

9 lines changed: 0 ins; 0 del; 9 mod; 2722 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compileTask.cpp

3 lines changed: 0 ins; 2 del; 1 mod; 504 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

15 lines changed: 10 ins; 0 del; 5 mod; 2704 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciRuntime.cpp

14 lines changed: 7 ins; 2 del; 5 mod; 1578 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

3 lines changed: 1 ins; 0 del; 2 mod; 2442 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 1188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.hpp

1 line changed: 0 ins; 0 del; 1 mod; 2473 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 2397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/deoptimization.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 2379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

78 lines changed: 73 ins; 3 del; 2 mod; 5044 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.hpp

5 lines changed: 5 ins; 0 del; 0 mod; 2343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/tieredThresholdPolicy.cpp

21 lines changed: 17 ins; 0 del; 4 mod; 983 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmOperations.hpp

1 line changed: 1 ins; 0 del; 0 mod; 523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java

12 lines changed: 12 ins; 0 del; 0 mod; 969 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCICompilerConfig.java

14 lines changed: 10 ins; 0 del; 4 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java

20 lines changed: 20 ins; 0 del; 0 mod; 1012 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java

4 lines changed: 0 ins; 0 del; 4 mod; 740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/SharedLibraryJVMCIReflection.java

9 lines changed: 6 ins; 0 del; 3 mod; 357 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/TranslatedException.java

92 lines changed: 55 ins; 10 del; 27 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/ProblemList-graal.txt

1 line changed: 1 ins; 0 del; 0 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/AsResolvedJavaMethodTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/DoNotInlineOrCompileTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/FindUniqueConcreteMethodTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetBytecodeTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetClassInitializerTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetConstantPoolTest.java

1 line changed: 0 ins; 0 del; 1 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetExceptionTableTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetImplementorTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetLineNumberTableTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetLocalVariableTableTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetResolvedJavaMethodTest.java

1 line changed: 0 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetResolvedJavaTypeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetStackTraceElementTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetSymbolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/GetVtableIndexForInterfaceTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/HasFinalizableSubclassTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/HasNeverInlineDirectiveTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/IsCompilableTest.java

3 lines changed: 0 ins; 2 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupKlassInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupKlassRefIndexInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupMethodInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupNameAndTypeRefIndexInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupNameInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupSignatureInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/LookupTypeTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/MethodIsIgnoredBySecurityStackWalkTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/ReadConfigurationTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/ResolveConstantInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/ResolveFieldInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/ResolveMethodTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/ResolvePossiblyCachedConstantInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/ResolveTypeInPoolTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/compilerToVM/ShouldInlineMethodTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/errors/TestInvalidCompilationResult.java

2 lines changed: 0 ins; 0 del; 2 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/errors/TestInvalidDebugInfo.java

2 lines changed: 0 ins; 0 del; 2 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/errors/TestInvalidOopMap.java

2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/events/JvmciNotifyInstallEventTest.java

1 line changed: 0 ins; 0 del; 1 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/DataPatchTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/InterpreterFrameSizeTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/MaxOopMapStackOffsetTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleCodeInstallationTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/VirtualObjectDebugInfoTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/HotSpotConstantReflectionProviderTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/MemoryAccessProviderTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/MethodHandleAccessProviderTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ConstantTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/RedefineClassTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ResolvedJavaTypeResolveConcreteMethodTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ResolvedJavaTypeResolveMethodTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestConstantReflectionProvider.java

2 lines changed: 0 ins; 0 del; 2 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestJavaField.java

2 lines changed: 0 ins; 0 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestJavaMethod.java

2 lines changed: 0 ins; 0 del; 2 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestJavaType.java

2 lines changed: 0 ins; 0 del; 2 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestMetaAccessProvider.java

2 lines changed: 0 ins; 0 del; 2 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaField.java

1 line changed: 0 ins; 0 del; 1 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaMethod.java

1 line changed: 0 ins; 0 del; 1 mod; 515 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJavaType.java

2 lines changed: 0 ins; 0 del; 2 mod; 1034 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/jvmci/meta/StableFieldTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 60 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestTranslatedException.java

76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/whitebox/OSRFailureLevel4Test.java

99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/kvn/work/hotspot/hg_webrev (vers 23.18-hg-never).