Code Review for jdk-hs

Prepared by:rkennke on Wed Nov 22 18:53:58 CET 2017
Workspace:/home/rkennke/src/openjdk/jdk-hs
Compare against: ssh://hg.openjdk.java.net/jdk/hs/
Compare against version:47956
Summary of changes: 965 lines changed: 336 ins; 555 del; 74 mod; 32241 unchg
Changeset: jdk-hs.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
84 lines changed: 84 ins; 0 del; 0 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
8 lines changed: 7 ins; 1 del; 0 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
6 lines changed: 0 ins; 0 del; 6 mod; 8154 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 1802 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
2 lines changed: 0 ins; 0 del; 2 mod; 1491 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/parNewGeneration.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 417 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
56 lines changed: 55 ins; 0 del; 1 mod; 5395 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
11 lines changed: 11 ins; 0 del; 0 mod; 1543 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1FullGCScope.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
62 lines changed: 62 ins; 0 del; 0 mod; 676 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
13 lines changed: 12 ins; 0 del; 1 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psMarkSweep.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 671 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 3184 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psScavenge.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 783 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/defNewGeneration.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
2 lines changed: 1 ins; 0 del; 1 mod; 1045 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/defNewGeneration.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/serialHeap.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
65 lines changed: 65 ins; 0 del; 0 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/serialHeap.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
8 lines changed: 7 ins; 1 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/tenuredGeneration.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 1 ins; 0 del; 2 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/tenuredGeneration.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
2 lines changed: 1 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/cardGeneration.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 1 ins; 0 del; 2 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/cardGeneration.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
6 lines changed: 6 ins; 0 del; 0 mod; 680 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
5 lines changed: 2 ins; 0 del; 3 mod; 1156 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
7 lines changed: 7 ins; 0 del; 0 mod; 490 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/generation.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 1 ins; 0 del; 2 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/generation.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
8 lines changed: 7 ins; 0 del; 1 mod; 558 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/generationSpec.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
6 lines changed: 0 ins; 0 del; 6 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/generationSpec.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
2 lines changed: 0 ins; 0 del; 2 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryManager.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
34 lines changed: 0 ins; 33 del; 1 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryManager.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
78 lines changed: 2 ins; 75 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryPool.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
26 lines changed: 0 ins; 26 del; 0 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryPool.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
17 lines changed: 0 ins; 16 del; 1 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryService.cpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
365 lines changed: 2 ins; 341 del; 22 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryService.hpp

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
64 lines changed: 0 ins; 58 del; 6 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1MemoryPool.cpp (was src/hotspot/share/services/g1MemoryPool.cpp)

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 1 ins; 1 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1MemoryPool.hpp (was src/hotspot/share/services/g1MemoryPool.hpp)

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 0 ins; 2 del; 1 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psMemoryPool.cpp (was src/hotspot/share/services/psMemoryPool.cpp)

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 1 ins; 1 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psMemoryPool.hpp (was src/hotspot/share/services/psMemoryPool.hpp)

rev 47957 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).