Code Review for shenandoah-jdk

Prepared by:rkennke on Wed Sep 19 18:03:21 CEST 2018
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk
Compare against: ssh://hg.openjdk.java.net/shenandoah/jdk/
Compare against version:52370
Summary of changes: 6620 lines changed: 4048 ins; 2509 del; 63 mod; 15725 unchg
Changeset: shenandoah-jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp 

rev 52371 : [mq]: lvb.patch
788 lines changed: 0 ins; 787 del; 1 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp 

rev 52371 : [mq]: lvb.patch
63 lines changed: 0 ins; 61 del; 2 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/barrierSetConfig.hpp 

rev 52371 : [mq]: lvb.patch
4 lines changed: 2 ins; 0 del; 2 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/barrierSetConfig.inline.hpp 

rev 52371 : [mq]: lvb.patch
3 lines changed: 2 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp 

rev 52371 : [mq]: lvb.patch
177 lines changed: 0 ins; 176 del; 1 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp 

rev 52371 : [mq]: lvb.patch
182 lines changed: 1 ins; 173 del; 8 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp 

rev 52371 : [mq]: lvb.patch
665 lines changed: 0 ins; 665 del; 0 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp 

rev 52371 : [mq]: lvb.patch
95 lines changed: 1 ins; 93 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp 

rev 52371 : [mq]: lvb.patch
2 lines changed: 0 ins; 0 del; 2 mod; 4349 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp 

rev 52371 : [mq]: lvb.patch
5 lines changed: 5 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp 

rev 52371 : [mq]: lvb.patch
301 lines changed: 0 ins; 296 del; 5 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp 

rev 52371 : [mq]: lvb.patch
113 lines changed: 0 ins; 96 del; 17 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp 

rev 52371 : [mq]: lvb.patch
155 lines changed: 1 ins; 151 del; 3 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp 

rev 52371 : [mq]: lvb.patch
59 lines changed: 54 ins; 0 del; 5 mod; 2866 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp 

rev 52371 : [mq]: lvb.patch
5 lines changed: 0 ins; 0 del; 5 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp 

rev 52371 : [mq]: lvb.patch
3 lines changed: 3 ins; 0 del; 0 mod; 437 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/accessBackend.hpp 

rev 52371 : [mq]: lvb.patch
7 lines changed: 6 ins; 0 del; 1 mod; 1393 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/callGenerator.cpp 

rev 52371 : [mq]: lvb.patch
10 lines changed: 10 ins; 0 del; 0 mod; 1368 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/lcm.cpp 

rev 52371 : [mq]: lvb.patch
2 lines changed: 0 ins; 0 del; 2 mod; 1428 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/replacednodes.cpp 

rev 52371 : [mq]: lvb.patch
1 line changed: 0 ins; 0 del; 1 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/stringopts.cpp 

rev 52371 : [mq]: lvb.patch
26 lines changed: 23 ins; 0 del; 3 mod; 1981 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/stringopts.hpp 

rev 52371 : [mq]: lvb.patch
2 lines changed: 1 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java 

rev 52371 : [mq]: lvb.patch
10 lines changed: 0 ins; 10 del; 0 mod; 41 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBaseBarrierSetAssembler.hpp 

rev 52371 : [mq]: lvb.patch
123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBaseBarrierSetAssembler_x86.cpp 

rev 52371 : [mq]: lvb.patch
837 lines changed: 837 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBaseBarrierSetAssembler_x86.hpp 

rev 52371 : [mq]: lvb.patch
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahLRBBarrierSetAssembler_x86.cpp 

rev 52371 : [mq]: lvb.patch
109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahLRBBarrierSetAssembler_x86.hpp 

rev 52371 : [mq]: lvb.patch
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahBaseBarrierSetC1.cpp 

rev 52371 : [mq]: lvb.patch
220 lines changed: 220 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahBaseBarrierSetC1.hpp 

rev 52371 : [mq]: lvb.patch
198 lines changed: 198 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahLRBBarrierSetC1.cpp 

rev 52371 : [mq]: lvb.patch
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahLRBBarrierSetC1.hpp 

rev 52371 : [mq]: lvb.patch
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBaseBarrierSetC2.cpp 

rev 52371 : [mq]: lvb.patch
704 lines changed: 704 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBaseBarrierSetC2.hpp 

rev 52371 : [mq]: lvb.patch
125 lines changed: 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahLRBBarrierSetC2.cpp 

rev 52371 : [mq]: lvb.patch
195 lines changed: 195 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahLRBBarrierSetC2.hpp 

rev 52371 : [mq]: lvb.patch
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBaseBarrierSet.cpp 

rev 52371 : [mq]: lvb.patch
374 lines changed: 374 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBaseBarrierSet.hpp 

rev 52371 : [mq]: lvb.patch
162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBaseBarrierSet.inline.hpp 

rev 52371 : [mq]: lvb.patch
184 lines changed: 184 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBaseBarrierSetAssembler.cpp (was src/hotspot/share/gc/shenandoah/shenandoahBarrierSetAssembler.cpp) 

rev 52371 : [mq]: lvb.patch
3 lines changed: 0 ins; 1 del; 2 mod; 31 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBaseBarrierSetAssembler.hpp 

rev 52371 : [mq]: lvb.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahLRBBarrierSet.cpp 

rev 52371 : [mq]: lvb.patch
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahLRBBarrierSet.hpp 

rev 52371 : [mq]: lvb.patch
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahLRBBarrierSet.inline.hpp 

rev 52371 : [mq]: lvb.patch
191 lines changed: 191 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahLRBBarrierSetAssembler.hpp 

rev 52371 : [mq]: lvb.patch
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).