Code Review for 6817525

Prepared by:twisti on Wed Mar 30 07:00:36 PDT 2011
Workspace:/home/twisti/hotspot-comp/6817525
Compare against: ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot
Summary of changes: 115 lines changed: 13 ins; 25 del; 77 mod; 58983 unchg
Patch of changes: 6817525.patch
Printable review: 6817525.pdf
Author comments:
6817525: turn on method handle functionality by default for JSR 292
Summary: After appropriate testing, we need to turn on EnableMethodHandles and EnableInvokeDynamic by default.
Reviewed-by:

The options EnableMethodHandles and AnonymousClasses are deprecated
and will be removed in the future. EnableInvokeDynamic has changed
from an experimental flag to a diagnostic flag and is the remaining
option which turns on and off JSR 292 support (including method
handles and anonymous classes).

The default value for EnableInvokeDynamic is true for JDK 7 and later
and false otherwise. EnableInvokeDynamic, and thus JSR 292 support in
the VM, cannot be enabled when running with JDK 6 or earlier.

Bug id: 6817525 turn on method handle functionality by default for JSR 292
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/cppInterpreter_sparc.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 2266 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/interp_masm_sparc.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 2463 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/interpreter_sparc.cpp

1 line changed: 0 ins; 0 del; 1 mod; 460 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/templateTable_sparc.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 3843 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/interp_masm_x86_32.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1428 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/interp_masm_x86_64.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1510 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/interpreter_x86_32.cpp

1 line changed: 0 ins; 0 del; 1 mod; 278 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/interpreter_x86_64.cpp

1 line changed: 0 ins; 0 del; 1 mod; 392 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_32.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1867 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateInterpreter_x86_64.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1909 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateTable_x86_32.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 3614 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/templateTable_x86_64.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 3669 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classFileParser.cpp

11 lines changed: 0 ins; 0 del; 11 mod; 4604 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classFileParser.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.cpp

8 lines changed: 0 ins; 2 del; 6 mod; 3204 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

21 lines changed: 0 ins; 10 del; 11 mod; 2980 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

1 line changed: 0 ins; 0 del; 1 mod; 688 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/constantPoolKlass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 527 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/constantPoolOop.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 868 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/instanceKlass.hpp

1 line changed: 0 ins; 0 del; 1 mod; 1019 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/klass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 594 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/methodOop.hpp

1 line changed: 0 ins; 0 del; 1 mod; 832 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/methodHandles.cpp

12 lines changed: 0 ins; 8 del; 4 mod; 2709 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/unsafe.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1598 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

19 lines changed: 9 ins; 2 del; 8 mod; 3294 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

9 lines changed: 4 ins; 3 del; 2 mod; 3818 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2814 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4309 unchg

This code review page was prepared using /home/twisti/bin/webrev (vers 23.18-hg-never).