Code Review for jdk

Prepared by:darcy on Thu Apr 23 15:28:42 PDT 2015
Workspace:/home/darcy/JDK/9/hg/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Summary of changes: 142 lines changed: 0 ins; 2 del; 140 mod; 36309 unchg
Patch of changes: jdk.patch
Bug id: JDK-8078468 : Update security libraries to use diamond with anonymous classes
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java

1 line changed: 0 ins; 0 del; 1 mod; 916 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/PBEKeyFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java

1 line changed: 0 ins; 0 del; 1 mod; 791 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/AccessControlContext.java

1 line changed: 0 ins; 0 del; 1 mod; 950 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/AccessController.java

1 line changed: 0 ins; 0 del; 1 mod; 895 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/AllPermission.java

1 line changed: 0 ins; 0 del; 1 mod; 227 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/BasicPermission.java

2 lines changed: 0 ins; 0 del; 2 mod; 552 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/CodeSource.java

1 line changed: 0 ins; 0 del; 1 mod; 644 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Identity.java

2 lines changed: 0 ins; 0 del; 2 mod; 493 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/IdentityScope.java

1 line changed: 0 ins; 0 del; 1 mod; 256 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/KeyStore.java

1 line changed: 0 ins; 0 del; 1 mod; 2246 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Permissions.java

4 lines changed: 0 ins; 0 del; 4 mod; 599 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Policy.java

3 lines changed: 0 ins; 0 del; 3 mod; 850 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/ProtectionDomain.java

1 line changed: 0 ins; 0 del; 1 mod; 489 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Provider.java

10 lines changed: 0 ins; 0 del; 10 mod; 1840 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/SecureRandom.java

1 line changed: 0 ins; 0 del; 1 mod; 688 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Security.java

2 lines changed: 0 ins; 0 del; 2 mod; 1124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Signature.java

1 line changed: 0 ins; 0 del; 1 mod; 1348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/Signer.java

1 line changed: 0 ins; 0 del; 1 mod; 182 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/UnresolvedPermission.java

1 line changed: 0 ins; 0 del; 1 mod; 601 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/UnresolvedPermissionCollection.java

3 lines changed: 0 ins; 0 del; 3 mod; 217 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/CertPathBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 330 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/CertPathValidator.java

1 line changed: 0 ins; 0 del; 1 mod; 342 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/CertStore.java

1 line changed: 0 ins; 0 del; 1 mod; 421 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/CertificateRevokedException.java

1 line changed: 0 ins; 0 del; 1 mod; 248 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/PKIXParameters.java

16 lines changed: 0 ins; 1 del; 15 mod; 720 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/PKIXRevocationChecker.java

2 lines changed: 0 ins; 0 del; 2 mod; 316 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/X509CRLSelector.java

8 lines changed: 0 ins; 0 del; 8 mod; 706 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/cert/X509CertSelector.java

14 lines changed: 0 ins; 0 del; 14 mod; 2609 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/crypto/JceSecurity.java

2 lines changed: 0 ins; 0 del; 2 mod; 338 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/crypto/JceSecurityManager.java

1 line changed: 0 ins; 0 del; 1 mod; 263 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/net/ssl/KeyManagerFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 289 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 304 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 286 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/security/auth/Subject.java

16 lines changed: 0 ins; 0 del; 16 mod; 1552 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/security/auth/login/Configuration.java

3 lines changed: 0 ins; 0 del; 3 mod; 611 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/javax/security/cert/X509Certificate.java

1 line changed: 0 ins; 0 del; 1 mod; 453 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/pkcs/PKCS7.java

2 lines changed: 0 ins; 0 del; 2 mod; 955 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/pkcs/PKCS9Attributes.java

2 lines changed: 0 ins; 1 del; 1 mod; 363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/pkcs/SignerInfo.java

1 line changed: 0 ins; 0 del; 1 mod; 562 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/SeedGenerator.java

3 lines changed: 0 ins; 0 del; 3 mod; 550 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SunJSSE.java

1 line changed: 0 ins; 0 del; 1 mod; 244 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/DerInputStream.java

1 line changed: 0 ins; 0 del; 1 mod; 626 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/ManifestDigester.java

1 line changed: 0 ins; 0 del; 1 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java

3 lines changed: 0 ins; 0 del; 3 mod; 247 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java

2 lines changed: 0 ins; 0 del; 2 mod; 654 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/AVA.java

1 line changed: 0 ins; 0 del; 1 mod; 1355 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/AlgorithmId.java

3 lines changed: 0 ins; 0 del; 3 mod; 977 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/CertificatePolicySet.java

1 line changed: 0 ins; 0 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/GeneralSubtrees.java

2 lines changed: 0 ins; 0 del; 2 mod; 523 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/RDN.java

3 lines changed: 0 ins; 0 del; 3 mod; 503 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/X500Name.java

2 lines changed: 0 ins; 0 del; 2 mod; 1439 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/security/provider/NativePRNG.java

2 lines changed: 0 ins; 0 del; 2 mod; 499 unchg

This code review page was prepared using /home/darcy/JDK/webrev/webrev.ksh (vers 25.6-hg+openjdk.java.net).