Code Review for jdk

Prepared by:hannesw on Tue Jan 7 15:25:52 CET 2020
Workspace:/Users/hannes/Work/jdk
Summary of changes: 1040 lines changed: 128 ins; 479 del; 433 mod; 21004 unchg
Patch of changes: jdk.patch
Bug id: JDK-8220002 : improve anchor definitions in generated files
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java

13 lines changed: 1 ins; 11 del; 1 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java

16 lines changed: 0 ins; 16 del; 0 mod; 717 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java

30 lines changed: 2 ins; 19 del; 9 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java

12 lines changed: 1 ins; 9 del; 2 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java

27 lines changed: 2 ins; 17 del; 8 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java

9 lines changed: 9 ins; 0 del; 0 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java

2 lines changed: 0 ins; 1 del; 1 mod; 446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java

9 lines changed: 2 ins; 2 del; 5 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java

32 lines changed: 4 ins; 20 del; 8 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java

18 lines changed: 2 ins; 14 del; 2 mod; 434 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java

26 lines changed: 3 ins; 17 del; 6 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java

33 lines changed: 4 ins; 20 del; 9 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java

37 lines changed: 6 ins; 19 del; 12 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java

15 lines changed: 1 ins; 3 del; 11 mod; 914 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java

25 lines changed: 3 ins; 19 del; 3 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java

2 lines changed: 0 ins; 0 del; 2 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java

36 lines changed: 5 ins; 22 del; 9 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java

1 line changed: 0 ins; 0 del; 1 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SubWriterHolderWriter.java

10 lines changed: 2 ins; 4 del; 4 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 517 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java

55 lines changed: 26 ins; 29 del; 0 mod; 992 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Links.java

45 lines changed: 0 ins; 45 del; 0 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java

64 lines changed: 16 ins; 45 del; 3 mod; 952 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java

15 lines changed: 15 ins; 0 del; 0 mod; 536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AnnotationTypeFieldWriter.java

4 lines changed: 0 ins; 1 del; 3 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AnnotationTypeRequiredMemberWriter.java

4 lines changed: 0 ins; 1 del; 3 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/ConstructorWriter.java

6 lines changed: 0 ins; 4 del; 2 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/FieldWriter.java

4 lines changed: 0 ins; 2 del; 2 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/MethodWriter.java

4 lines changed: 0 ins; 2 del; 2 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/PropertyWriter.java

6 lines changed: 0 ins; 4 del; 2 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeFieldBuilder.java

3 lines changed: 0 ins; 1 del; 2 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java

3 lines changed: 0 ins; 1 del; 2 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ConstructorBuilder.java

3 lines changed: 0 ins; 1 del; 2 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/FieldBuilder.java

2 lines changed: 0 ins; 0 del; 2 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MethodBuilder.java

3 lines changed: 0 ins; 1 del; 2 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PropertyBuilder.java

4 lines changed: 0 ins; 2 del; 2 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DeprecatedAPIListBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/AccessSkipNav/AccessSkipNav.java

6 lines changed: 0 ins; 0 del; 6 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/constantValues/TestConstantValuesDriver.java

7 lines changed: 0 ins; 0 del; 7 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testAnchorNames/TestAnchorNames.java

34 lines changed: 4 ins; 0 del; 30 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testAnnotationOptional/TestAnnotationOptional.java

1 line changed: 0 ins; 0 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testAnnotationTypes/TestAnnotationTypes.java

6 lines changed: 1 ins; 1 del; 4 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testConstructors/TestConstructors.java

6 lines changed: 0 ins; 0 del; 6 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testDeprecatedDocs/TestDeprecatedDocs.java

5 lines changed: 0 ins; 1 del; 4 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testHeadings/TestHeadings.java

2 lines changed: 1 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testHiddenTag/TestHiddenTag.java

9 lines changed: 1 ins; 2 del; 6 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testHref/TestHref.java

3 lines changed: 0 ins; 2 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testHtmlTableStyles/TestHtmlTableStyles.java

1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java

4 lines changed: 0 ins; 0 del; 4 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testHtmlTag/TestHtmlTag.java

3 lines changed: 0 ins; 2 del; 1 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java

130 lines changed: 1 ins; 84 del; 45 mod; 743 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testIndexInDocFiles/TestIndexInDocFiles.java

8 lines changed: 0 ins; 0 del; 8 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testIndexInPackageFiles/TestIndexInPackageFiles.java

5 lines changed: 0 ins; 0 del; 5 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testIndexTaglet/TestIndexTaglet.java

4 lines changed: 0 ins; 0 del; 4 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java

9 lines changed: 3 ins; 2 del; 4 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java

32 lines changed: 9 ins; 4 del; 19 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testLinkToSerialForm/TestLinkToSerialForm.java

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testMemberInheritance/TestMemberInheritance.java

2 lines changed: 1 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testMemberSummary/TestMemberSummary.java

3 lines changed: 0 ins; 1 del; 2 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testModules/TestModules.java

52 lines changed: 0 ins; 18 del; 34 mod; 1298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testNavigation/TestNavigation.java

19 lines changed: 0 ins; 6 del; 13 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java

18 lines changed: 2 ins; 0 del; 16 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testOrdering/TestOrdering.java

32 lines changed: 0 ins; 0 del; 32 mod; 594 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestBadOverride.java

2 lines changed: 0 ins; 0 del; 2 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverrideMethods.java

5 lines changed: 0 ins; 1 del; 4 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testPackageDescription/TestPackageDescription.java

3 lines changed: 0 ins; 2 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/TestRecordTypes.java

8 lines changed: 0 ins; 0 del; 8 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java

6 lines changed: 0 ins; 0 del; 6 mod; 700 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testSummaryTag/TestSummaryTag.java

2 lines changed: 0 ins; 0 del; 2 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testSystemPropertyTaglet/TestSystemPropertyTaglet.java

21 lines changed: 0 ins; 0 del; 21 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testTypeParams/TestTypeParameters.java

2 lines changed: 1 ins; 0 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testUseOption/TestUseOption.java

1 line changed: 0 ins; 0 del; 1 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testValueTag/TestValueTagInModule.java

3 lines changed: 0 ins; 1 del; 2 mod; 81 unchg

This code review page was prepared using ../../webrev.ksh (vers 25.16-hg+openjdk.java.net).