Code Review for langtools

Prepared by: Jan Lahoda (jlahoda) on Wed Feb 8 11:44:30 PST 2017
Workspace:/scratch/jlahoda/hudson-standalone/.hudson/jobs/patch-module-patches/workspace/sandbox/langtools
Summary of changes: 1464 lines changed: 999 ins; 362 del; 103 mod; 21362 unchg
Patch of changes: langtools.patch
Author comments:
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/tools/StandardLocation.java

9 lines changed: 8 ins; 0 del; 1 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java

1 line changed: 0 ins; 0 del; 1 mod; 831 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java

40 lines changed: 27 ins; 0 del; 13 mod; 750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/ModuleFinder.java

40 lines changed: 36 ins; 0 del; 4 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java

2 lines changed: 2 ins; 0 del; 0 mod; 2214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java

106 lines changed: 80 ins; 11 del; 15 mod; 1575 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java

1 line changed: 0 ins; 0 del; 1 mod; 1159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

155 lines changed: 86 ins; 57 del; 12 mod; 1638 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java

3 lines changed: 0 ins; 3 del; 0 mod; 948 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java

5 lines changed: 5 ins; 0 del; 0 mod; 1822 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java

1 line changed: 0 ins; 0 del; 1 mod; 1313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties

13 lines changed: 6 ins; 0 del; 7 mod; 3054 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java

7 lines changed: 0 ins; 7 del; 0 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties

1 line changed: 0 ins; 1 del; 0 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ToolOption.java

7 lines changed: 0 ins; 7 del; 0 mod; 590 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc.properties

5 lines changed: 0 ins; 5 del; 0 mod; 309 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/MemoryFileManager.java

63 lines changed: 20 ins; 43 del; 0 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/6627362/T6627362.java

2 lines changed: 0 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/diags/Example.java

16 lines changed: 16 ins; 0 del; 0 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/diags/examples.not-yet.txt

1 line changed: 1 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/modules/AddLimitMods.java

1 line changed: 0 ins; 0 del; 1 mod; 596 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/modules/AddReadsTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 663 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/modules/InheritRuntimeEnvironmentTest.java

1 line changed: 0 ins; 0 del; 1 mod; 425 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/modules/PatchModulesTest.java

57 lines changed: 44 ins; 2 del; 11 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/modules/XModuleTest.java

354 lines changed: 299 ins; 27 del; 28 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/synthesize/Main.java

9 lines changed: 5 ins; 3 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jdeps/jdkinternals/RemovedJDKInternals.java

1 line changed: 0 ins; 0 del; 1 mod; 148 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/6627362/x/java/lang/Object.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClassoutput/ModuleInfoWithPatchedModuleClassoutput.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClassoutput/additional/module-info.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClassoutput/patchmodule/java.compiler/javax/lang/model/element/Extra.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcepath/ModuleInfoWithPatchedModule.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcepath/patchmodule/java.compiler/javax/lang/model/element/Extra.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcepath/patchmodule/java.compiler/module-info.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/NoSuperclass/NoSuperclass.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/NoSuperclass/patchmodule/java.base/java/lang/Object.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/TooManyPatchedModules/TooManyPatchedModules.java

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/TooManyPatchedModules/patchmodule/java.compiler/p/C.java

25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/TooManyPatchedModules/patchmodule/jdk.compiler/p/C.java

25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/meth/BadPolySig/BadPolySig.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/meth/BadPolySig/java.base/java/lang/invoke/MethodHandle.java

28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/6627362/x/Object.java

30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/ModuleInfoWithXModuleSourcePath/Extra.java

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/ModuleInfoWithXModuleSourcePath/module-info.java

24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/ModuleInfoWithXmoduleClasspath/ModuleInfoWithXmoduleClasspath.java

29 lines changed: 0 ins; 29 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/ModuleInfoWithXmoduleClasspath/additional/module-info.java

24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/NoSuperclass.java

33 lines changed: 0 ins; 33 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/XModuleWithModulePath/XModuleWithModulePath.java

27 lines changed: 0 ins; 27 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/jlahoda/hudson-standalone/.hudson/jobs/patch-module-patches/workspace/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).