Code Review for jdk

Prepared by:mduigou on Fri Jul 26 16:17:32 PDT 2013
Workspace:/home/mike/code/jdk/tl8/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8/tl-gate/jdk
Compare against version:7681
Summary of changes: 420 lines changed: 375 ins; 10 del; 35 mod; 23557 unchg
Changeset: jdk.changeset
Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/Collections.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 5571 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/Hashtable.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
3 lines changed: 3 ins; 0 del; 0 mod; 1467 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/IdentityHashMap.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
2 lines changed: 2 ins; 0 del; 0 mod; 1596 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/Map.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
8 lines changed: 7 ins; 0 del; 1 mod; 1190 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/TreeMap.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
22 lines changed: 21 ins; 0 del; 1 mod; 2949 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/util/concurrent/ConcurrentHashMap.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
3 lines changed: 3 ins; 0 del; 0 mod; 6174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/javax/security/auth/Subject.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
2 lines changed: 0 ins; 0 del; 2 mod; 1439 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collection/CollectionDefaults.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
29 lines changed: 15 ins; 1 del; 13 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collection/MOAT.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
2 lines changed: 0 ins; 2 del; 0 mod; 1280 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collection/testlibrary/CollectionAsserts.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
26 lines changed: 19 ins; 0 del; 7 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Collection/testlibrary/CollectionSupplier.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
3 lines changed: 0 ins; 2 del; 1 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Map/Defaults.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
37 lines changed: 26 ins; 2 del; 9 mod; 724 unchg

------ ------ ------ ------ --- New ----- Raw test/java/util/Collection/testlibrary/ExtendsAbstractCollection.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/util/Collection/testlibrary/ExtendsAbstractList.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/util/Collection/testlibrary/ExtendsAbstractSet.java

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/List/ListDefaults.java (was test/java/util/Collection/ListDefaults.java)

rev 7682 : 8021591: Additional explicit null checks
Reviewed-by: duke
10 lines changed: 6 ins; 3 del; 1 mod; 525 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.0-hg+jbs).