Code Review for open

Prepared by:stefank on Thu Nov 21 11:53:22 CET 2019
Workspace:/home/stefank/hg/jdk/jdk/open
Compare against version:-2
Summary of changes: 227 lines changed: 0 ins; 1 del; 226 mod; 65263 unchg
Patch of changes: open.patch
Bug id: JDK-8234563 : Harmonize parameter order in Atomic
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/stubGenerator_arm.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3093 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/sparc/stubGenerator_sparc.cpp

1 line changed: 0 ins; 0 del; 1 mod; 5870 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 3807 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

1 line changed: 0 ins; 0 del; 1 mod; 6314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/bsd_zero/atomic_bsd_zero.hpp

8 lines changed: 0 ins; 0 del; 8 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp

5 lines changed: 0 ins; 0 del; 5 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_sparc/atomic_linux_sparc.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_zero/atomic_linux_zero.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/solaris_sparc/atomic_solaris_sparc.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/solaris_x86/atomic_solaris_x86.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/solaris_x86/solaris_x86_64.il

2 lines changed: 0 ins; 0 del; 2 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp

10 lines changed: 0 ins; 0 del; 10 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataGraph.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 809 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/symbolTable.cpp

1 line changed: 0 ins; 0 del; 1 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compileBroker.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 2771 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 4926 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectionSetChooser.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 3069 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1EvacStats.inline.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp

1 line changed: 0 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1HotCardCache.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp

1 line changed: 0 ins; 0 del; 1 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RedirtyCardsQueue.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RegionMarkStatsCache.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1RemSet.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 1689 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parMarkBitMap.cpp

1 line changed: 0 ins; 0 del; 1 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 3316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 1307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1055 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/plab.inline.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/preservedMarks.cpp

1 line changed: 0 ins; 0 del; 1 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/ptrQueue.cpp

3 lines changed: 0 ins; 1 del; 2 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp

1 line changed: 0 ins; 0 del; 1 mod; 392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/stringdedup/stringDedupQueue.cpp

1 line changed: 0 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp

1 line changed: 0 ins; 0 del; 1 mod; 647 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/workgroup.cpp

1 line changed: 0 ins; 0 del; 1 mod; 496 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp

1 line changed: 0 ins; 0 del; 1 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp

1 line changed: 0 ins; 0 del; 1 mod; 622 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 3004 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 533 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp

1 line changed: 0 ins; 0 del; 1 mod; 699 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp

1 line changed: 0 ins; 0 del; 1 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahPacer.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp

1 line changed: 0 ins; 0 del; 1 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 1016 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zArray.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zLiveMap.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMarkStackAllocator.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMarkTerminate.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zNMethodTableIteration.cpp

1 line changed: 0 ins; 0 del; 1 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zObjectAllocator.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocationSet.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zStat.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 1422 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/utilities/jfrRefCountPointer.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logOutputList.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 966 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/resolvedMethodTable.cpp

1 line changed: 0 ins; 0 del; 1 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/atomic.hpp

34 lines changed: 0 ins; 0 del; 34 mod; 921 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1825 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/threadSMR.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/threadSMR.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/mallocSiteTable.hpp

1 line changed: 0 ins; 0 del; 1 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/mallocTracker.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalCounter.cpp

1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/singleWriterSynchronizer.cpp

1 line changed: 0 ins; 0 del; 1 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/singleWriterSynchronizer.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/waitBarrier_generic.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/g1/test_g1FreeIdSet.cpp

1 line changed: 0 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp

1 line changed: 0 ins; 0 del; 1 mod; 249 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).