| Prepared by: | dcubed on Mon Feb 3 17:40:09 EST 2020 |
|---|---|
| Workspace: | /work/shared/bug_hunt/8183909/8153224_mach5_for_jdk14/open |
| Compare against: | /work/shared/bug_hunt/8183909/8153224_base_for_jdk14/open |
| Compare against version: | 8235795.patch.cr3 |
| Summary of changes: | 2154 lines changed: 1807 ins; 85 del; 262 mod; 47995 unchg |
| Patch of changes: | open.patch |
| Bug id: | JDK-8153224 : Monitor deflation prolong safepoints |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/aarch64/globals_aarch64.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.4 lines changed: 4 ins; 0 del; 0 mod; 117 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/arm/globals_arm.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.5 lines changed: 5 ins; 0 del; 0 mod; 81 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/ppc/globals_ppc.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.4 lines changed: 4 ins; 0 del; 0 mod; 201 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/s390/globals_s390.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.4 lines changed: 4 ins; 0 del; 0 mod; 122 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/sparc/globals_sparc.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.4 lines changed: 4 ins; 0 del; 0 mod; 130 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/x86/globals_x86.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.15 lines changed: 15 ins; 0 del; 0 mod; 215 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/x86/macroAssembler_x86.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.128 lines changed: 116 ins; 4 del; 8 mod; 9991 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/x86/macroAssembler_x86.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.1 line changed: 1 ins; 0 del; 0 mod; 1839 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/cpu/zero/globals_zero.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.4 lines changed: 4 ins; 0 del; 0 mod; 92 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/oops/markWord.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.4 lines changed: 4 ins; 0 del; 0 mod; 372 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/prims/jvm.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.6 lines changed: 6 ins; 0 del; 0 mod; 3679 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/prims/jvmtiEnvBase.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.20 lines changed: 16 ins; 0 del; 4 mod; 1592 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/prims/whitebox.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.13 lines changed: 13 ins; 0 del; 0 mod; 2462 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/basicLock.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.5 lines changed: 4 ins; 0 del; 1 mod; 77 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/globals.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.18 lines changed: 14 ins; 0 del; 4 mod; 2550 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/init.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.6 lines changed: 4 ins; 0 del; 2 mod; 211 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/objectMonitor.cpp
rev 57587 : imported patch 8236035.patch.cr0 rev 57588 : dholmes CR - rename simply_set_owner_from() -> set_owner_from() and simply_set_owner_from_BasicLock() -> set_owner_from_BasicLock(); rename release_clear_owner_with_barrier() -> release_clear_owner() and refactor barrier code back into the call sites. rev 57589 : kbarrett CR - rearrange some loads of _owner field to be more efficient; clarify header comment for try_set_owner_from() declaration; make some loads of _owner field DEBUG_ONLY since they only exist for assert()'s; update related logging calls to use the existing function parameter instead. rev 57591 : imported patch 8235795.patch.cr0.merged rev 57593 : coleenp CR part1: add ObjectMonitor::next_om(), set_next_om(), and try_set_next_om(); ObjectMonitor::_next_om field is now private; rename ListGlobals -> ObjectMonitorListGlobals, rename LVars -> om_list_globals, and prefix each ObjectMonitorListGlobals field with '_'; delete static set_next() function; clarify comments; coleenp CR part2: delete stale comments about mux*(). rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.305 lines changed: 290 ins; 2 del; 13 mod; 1996 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/objectMonitor.hpp
rev 57586 : imported patch 8235931.patch.cr0 rev 57587 : imported patch 8236035.patch.cr0 rev 57588 : dholmes CR - rename simply_set_owner_from() -> set_owner_from() and simply_set_owner_from_BasicLock() -> set_owner_from_BasicLock(); rename release_clear_owner_with_barrier() -> release_clear_owner() and refactor barrier code back into the call sites. rev 57589 : kbarrett CR - rearrange some loads of _owner field to be more efficient; clarify header comment for try_set_owner_from() declaration; make some loads of _owner field DEBUG_ONLY since they only exist for assert()'s; update related logging calls to use the existing function parameter instead. rev 57590 : dholmes CR - simplify comment for try_set_owner_from(); self-review: add return value comment to try_set_owner_from() definition. rev 57591 : imported patch 8235795.patch.cr0.merged rev 57593 : coleenp CR part1: add ObjectMonitor::next_om(), set_next_om(), and try_set_next_om(); ObjectMonitor::_next_om field is now private; rename ListGlobals -> ObjectMonitorListGlobals, rename LVars -> om_list_globals, and prefix each ObjectMonitorListGlobals field with '_'; delete static set_next() function; clarify comments; coleenp CR part2: delete stale comments about mux*(). rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.90 lines changed: 77 ins; 0 del; 13 mod; 328 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/objectMonitor.inline.hpp
rev 57587 : imported patch 8236035.patch.cr0 rev 57588 : dholmes CR - rename simply_set_owner_from() -> set_owner_from() and simply_set_owner_from_BasicLock() -> set_owner_from_BasicLock(); rename release_clear_owner_with_barrier() -> release_clear_owner() and refactor barrier code back into the call sites. rev 57589 : kbarrett CR - rearrange some loads of _owner field to be more efficient; clarify header comment for try_set_owner_from() declaration; make some loads of _owner field DEBUG_ONLY since they only exist for assert()'s; update related logging calls to use the existing function parameter instead. rev 57590 : dholmes CR - simplify comment for try_set_owner_from(); self-review: add return value comment to try_set_owner_from() definition. rev 57593 : coleenp CR part1: add ObjectMonitor::next_om(), set_next_om(), and try_set_next_om(); ObjectMonitor::_next_om field is now private; rename ListGlobals -> ObjectMonitorListGlobals, rename LVars -> om_list_globals, and prefix each ObjectMonitorListGlobals field with '_'; delete static set_next() function; clarify comments; coleenp CR part2: delete stale comments about mux*(). rev 57594 : coleenp CR: add comment to explain why _next_om field uses Atomic ops. rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.108 lines changed: 96 ins; 1 del; 11 mod; 148 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/safepoint.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.12 lines changed: 9 ins; 0 del; 3 mod; 1289 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/serviceThread.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.11 lines changed: 9 ins; 0 del; 2 mod; 229 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/sharedRuntime.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.8 lines changed: 6 ins; 0 del; 2 mod; 3257 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/synchronizer.cpp
rev 57586 : imported patch 8235931.patch.cr0 rev 57587 : imported patch 8236035.patch.cr0 rev 57588 : dholmes CR - rename simply_set_owner_from() -> set_owner_from() and simply_set_owner_from_BasicLock() -> set_owner_from_BasicLock(); rename release_clear_owner_with_barrier() -> release_clear_owner() and refactor barrier code back into the call sites. rev 57591 : imported patch 8235795.patch.cr0.merged rev 57592 : dholmes CR - refactor common code, refactor atomic load of LVars.population in monitors_used_above_threshold, simplify list walking in ObjectSynchronizer::om_release() so we lock fewer ObjectMonitors, remove unnecessary locking from ObjectSynchronizer::deflate_monitor_list(), add NoSafepointVerifier helpers to main list management functions, remove unnecessary storestore(), remove unnecessary comments, clarify/fix comments. rev 57593 : coleenp CR part1: add ObjectMonitor::next_om(), set_next_om(), and try_set_next_om(); ObjectMonitor::_next_om field is now private; rename ListGlobals -> ObjectMonitorListGlobals, rename LVars -> om_list_globals, and prefix each ObjectMonitorListGlobals field with '_'; delete static set_next() function; clarify comments; coleenp CR part2: delete stale comments about mux*(). rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.1193 lines changed: 951 ins; 75 del; 167 mod; 2359 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/synchronizer.hpp
rev 57586 : imported patch 8235931.patch.cr0 rev 57591 : imported patch 8235795.patch.cr0.merged rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.37 lines changed: 29 ins; 0 del; 8 mod; 212 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/thread.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.6 lines changed: 5 ins; 0 del; 1 mod; 5080 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/thread.hpp
rev 57591 : imported patch 8235795.patch.cr0.merged rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.28 lines changed: 24 ins; 0 del; 4 mod; 2298 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/vframe.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.13 lines changed: 10 ins; 0 del; 3 mod; 736 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/vmOperations.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.12 lines changed: 12 ins; 0 del; 0 mod; 513 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/vmOperations.hpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.1 line changed: 1 ins; 0 del; 0 mod; 484 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/vmStructs.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.6 lines changed: 3 ins; 2 del; 1 mod; 3198 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/vmThread.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.9 lines changed: 9 ins; 0 del; 0 mod; 753 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/services/threadService.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.27 lines changed: 21 ins; 1 del; 5 mod; 1076 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
test/hotspot/gtest/oops/test_markWord.cpp
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.16 lines changed: 8 ins; 0 del; 8 mod; 142 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
test/hotspot/jtreg/runtime/logging/SafepointCleanupTest.java
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.26 lines changed: 26 ins; 0 del; 0 mod; 78 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
test/jdk/java/rmi/server/UnicastRemoteObject/unexportObject/UnexportLeak.java
rev 57595 : v2.09a with 8235795, 8235931 and 8236035 extracted; rebased to jdk-14+28; merge with 8236035.patch.cr1; merge with 8235795.patch.cr1; merge with 8236035.patch.cr2; merge with 8235795.patch.cr2; merge with 8235795.patch.cr3.5 lines changed: 3 ins; 0 del; 2 mod; 88 unchg
This code review page was prepared using /Users/dcubed/Bin/webrev (vers 25.18-hg+openjdk.java.net).