Code Review for langtools

Prepared by:dholmes on Fri Jan 18 02:50:49 EST 2013
Workspace:/export/users/dh198349/profiles-staging/langtools
Compare against: http://embedsrc.us.oracle.com/hg/jdk8/profiles-staging/langtools
Summary of changes: 4409 lines changed: 4354 ins; 9 del; 46 mod; 25097 unchg
Patch of changes: langtools.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java

37 lines changed: 32 ins; 0 del; 5 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java

17 lines changed: 15 ins; 1 del; 1 mod; 702 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java

20 lines changed: 17 ins; 0 del; 3 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java

41 lines changed: 40 ins; 0 del; 1 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java

102 lines changed: 101 ins; 0 del; 1 mod; 1996 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java

18 lines changed: 13 ins; 0 del; 5 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java

42 lines changed: 41 ins; 0 del; 1 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java

20 lines changed: 19 ins; 0 del; 1 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java

6 lines changed: 5 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java

28 lines changed: 27 ins; 0 del; 1 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties

4 lines changed: 4 ins; 0 del; 0 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java

10 lines changed: 7 ins; 2 del; 1 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java

68 lines changed: 66 ins; 0 del; 2 mod; 782 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java

29 lines changed: 28 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java

32 lines changed: 31 ins; 0 del; 1 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml

15 lines changed: 15 ins; 0 del; 0 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties

3 lines changed: 3 ins; 0 del; 0 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css

3 lines changed: 3 ins; 0 del; 0 mod; 517 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java

24 lines changed: 23 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java

16 lines changed: 15 ins; 0 del; 1 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 506 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/code/Flags.java

5 lines changed: 5 ins; 0 del; 0 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/code/Symtab.java

28 lines changed: 17 ins; 4 del; 7 mod; 700 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/comp/Attr.java

1 line changed: 1 ins; 0 del; 0 mod; 4099 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/comp/Check.java

10 lines changed: 9 ins; 0 del; 1 mod; 3331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/jvm/ClassReader.java

21 lines changed: 20 ins; 0 del; 1 mod; 2731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/jvm/Target.java

1 line changed: 0 ins; 0 del; 1 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/main/Main.java

13 lines changed: 11 ins; 0 del; 2 mod; 680 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/main/Option.java

13 lines changed: 13 ins; 0 del; 0 mod; 714 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/resources/compiler.properties

4 lines changed: 4 ins; 0 del; 0 mod; 2397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/resources/javac.properties

8 lines changed: 8 ins; 0 del; 0 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java

29 lines changed: 22 ins; 2 del; 5 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java

4 lines changed: 4 ins; 0 del; 0 mod; 529 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java

2 lines changed: 1 ins; 0 del; 1 mod; 683 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/AbstractProfileIndexWriter.java

276 lines changed: 276 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java

173 lines changed: 173 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java

187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java

200 lines changed: 200 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageWriterImpl.java

296 lines changed: 296 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/formats/html/ProfileWriterImpl.java

208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/ProfilePackageSummaryWriter.java

116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/ProfileSummaryWriter.java

120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfilePackageSummaryBuilder.java

374 lines changed: 374 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfileSummaryBuilder.java

328 lines changed: 328 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/javac/jvm/Profile.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/com/sun/tools/javac/sym/Profiles.java

298 lines changed: 298 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/TestProfiles.java

186 lines changed: 186 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg1/Class1Pkg1.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg1/Class2Pkg1.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg1/Class3Pkg1.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg1/Interface1Pkg1.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg2/Anno1Pkg2.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg2/Anno2Pkg2.java

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg2/Class1Pkg2.java

51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg3/Class1Pkg3.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg3/Class2Pkg3.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg3/Interface1Pkg3.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg4/Anno1Pkg4.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg4/Class1Pkg4.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg5/Class1Pkg5.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/pkg5/Interface1Pkg5.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/com/sun/javadoc/testProfiles/profile-rtjar-includes.txt

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/NotInProfile.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/profiles/ProfileOptionTest.java

268 lines changed: 268 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/dholmes /bin/webrev (vers 23.18-hg-never).