Code Review for hotspot

Prepared by:Doug Simon on Tue Jun 21 23:04:01 CEST 2016
Workspace:/Users/dsimon/hs-comp/hotspot
Summary of changes: 805 lines changed: 402 ins; 154 del; 249 mod; 9153 unchg
Patch of changes: hotspot.patch
Bug id: JDK-8159613] [Findbugs : various warnings reported for JVMCI sources
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .mx.jvmci/mx_jvmci.py

2 lines changed: 1 ins; 0 del; 1 mod; 809 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/AArch64.java

7 lines changed: 1 ins; 0 del; 6 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.amd64/src/jdk/vm/ci/amd64/AMD64.java

8 lines changed: 1 ins; 0 del; 7 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/Architecture.java

14 lines changed: 1 ins; 1 del; 12 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/BytecodeFrame.java

59 lines changed: 52 ins; 0 del; 7 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/CallingConvention.java

1 line changed: 1 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/DebugInfo.java

3 lines changed: 2 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/RegisterAttributes.java

16 lines changed: 6 ins; 2 del; 8 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/RegisterConfig.java

5 lines changed: 0 ins; 0 del; 5 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/RegisterSaveLayout.java

1 line changed: 1 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/VirtualObject.java

12 lines changed: 7 ins; 0 del; 5 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/InitTimer.java

3 lines changed: 0 ins; 0 del; 3 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotRegisterConfig.java

36 lines changed: 1 ins; 3 del; 32 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotVMConfig.java

5 lines changed: 0 ins; 5 del; 0 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotRegisterConfig.java

39 lines changed: 1 ins; 2 del; 36 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotVMConfig.java

5 lines changed: 0 ins; 5 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/jdk/vm/ci/hotspot/sparc/SPARCHotSpotRegisterConfig.java

39 lines changed: 1 ins; 4 del; 34 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCodeCacheProvider.java

3 lines changed: 1 ins; 0 del; 2 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCompiledCode.java

1 line changed: 1 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java

23 lines changed: 9 ins; 2 del; 12 mod; 702 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java

88 lines changed: 19 ins; 51 del; 18 mod; 498 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodData.java

104 lines changed: 40 ins; 44 del; 20 mod; 851 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotReferenceMap.java

16 lines changed: 12 ins; 0 del; 4 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java

7 lines changed: 3 ins; 0 del; 4 mod; 924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotSpeculationLog.java

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfig.java

25 lines changed: 18 ins; 3 del; 4 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfigAccess.java

3 lines changed: 0 ins; 0 del; 3 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/AbstractJavaProfile.java

6 lines changed: 6 ins; 0 del; 0 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/AbstractProfiledItem.java

10 lines changed: 4 ins; 4 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LineNumberTable.java

23 lines changed: 15 ins; 5 del; 3 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/Local.java

3 lines changed: 3 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LocalVariableTable.java

13 lines changed: 9 ins; 4 del; 0 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.sparc/src/jdk/vm/ci/sparc/SPARC.java

14 lines changed: 1 ins; 0 del; 13 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/amd64/AMD64TestAssembler.java

2 lines changed: 0 ins; 0 del; 2 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/sparc/SPARCTestAssembler.java

2 lines changed: 0 ins; 0 del; 2 mod; 289 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/RegisterArray.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/SuppressFBWarnings.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/SuppressFBWarnings.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVmSymbols.java

20 lines changed: 0 ins; 19 del; 1 mod; 28 unchg

This code review page was prepared using /Users/dsimon/Dropbox/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).