Code Review for nashorn8u-dev

Prepared by:hannesw on Wed Jan 20 14:15:04 CET 2016
Workspace:/home/hannes/work/nashorn8u-dev
Summary of changes: 2718 lines changed: 334 ins; 2267 del; 117 mod; 42024 unchg
Patch of changes: nashorn8u-dev.patch
Bug id: <title>[JDK-8144020] Remove long as an internal numeric type - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/CodeGenerator.java

82 lines changed: 44 ins; 24 del; 14 mod; 5456 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/FieldObjectCreator.java

7 lines changed: 0 ins; 5 del; 2 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/FoldConstants.java

8 lines changed: 1 ins; 5 del; 2 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/LocalVariableTypesCalculator.java

34 lines changed: 0 ins; 30 del; 4 mod; 1617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/MethodEmitter.java

1 line changed: 0 ins; 1 del; 0 mod; 2754 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java

19 lines changed: 0 ins; 18 del; 1 mod; 813 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/ObjectCreator.java

8 lines changed: 3 ins; 2 del; 3 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/SpillObjectCreator.java

5 lines changed: 0 ins; 2 del; 3 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/TypeEvaluator.java

1 line changed: 0 ins; 0 del; 1 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/types/IntType.java

1 line changed: 0 ins; 0 del; 1 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/types/LongType.java

103 lines changed: 0 ins; 102 del; 1 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/codegen/types/Type.java

1 line changed: 0 ins; 0 del; 1 mod; 1162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/ir/BinaryNode.java

14 lines changed: 5 ins; 6 del; 3 mod; 595 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/ir/LiteralNode.java

9 lines changed: 1 ins; 8 del; 0 mod; 974 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/ir/Symbol.java

16 lines changed: 0 ins; 13 del; 3 mod; 676 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/Global.java

13 lines changed: 0 ins; 13 del; 0 mod; 2737 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeArguments.java

6 lines changed: 0 ins; 6 del; 0 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeArray.java

42 lines changed: 26 ins; 1 del; 15 mod; 1889 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeFloat32Array.java

11 lines changed: 0 ins; 10 del; 1 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeFloat64Array.java

11 lines changed: 0 ins; 10 del; 1 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeInt16Array.java

15 lines changed: 0 ins; 15 del; 0 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeInt32Array.java

15 lines changed: 0 ins; 15 del; 0 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeInt8Array.java

15 lines changed: 0 ins; 15 del; 0 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeJSAdapter.java

120 lines changed: 0 ins; 120 del; 0 mod; 628 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeString.java

56 lines changed: 0 ins; 56 del; 0 mod; 1354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeUint16Array.java

15 lines changed: 0 ins; 15 del; 0 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeUint32Array.java

27 lines changed: 6 ins; 10 del; 11 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeUint8Array.java

15 lines changed: 0 ins; 15 del; 0 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java

15 lines changed: 0 ins; 15 del; 0 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/parser/JSONParser.java

4 lines changed: 0 ins; 4 del; 0 mod; 548 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/parser/Lexer.java

7 lines changed: 0 ins; 6 del; 1 mod; 1777 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/AccessorProperty.java

34 lines changed: 0 ins; 33 del; 1 mod; 726 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/DebuggerSupport.java

1 line changed: 0 ins; 0 del; 1 mod; 392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/DefaultPropertyAccess.java

85 lines changed: 0 ins; 85 del; 0 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/FindProperty.java

17 lines changed: 0 ins; 17 del; 0 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/GlobalFunctions.java

3 lines changed: 0 ins; 3 del; 0 mod; 521 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/JSType.java

339 lines changed: 30 ins; 298 del; 11 mod; 1681 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/OptimisticReturnFilters.java

67 lines changed: 9 ins; 41 del; 17 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/Property.java

23 lines changed: 0 ins; 23 del; 0 mod; 696 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/PropertyAccess.java

133 lines changed: 0 ins; 133 del; 0 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ScriptObject.java

306 lines changed: 0 ins; 306 del; 0 mod; 3512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/UnwarrantedOptimismException.java

23 lines changed: 19 ins; 2 del; 2 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/UserAccessorProperty.java

36 lines changed: 0 ins; 36 del; 0 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/ArrayData.java

63 lines changed: 0 ins; 59 del; 4 mod; 886 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/ArrayFilter.java

17 lines changed: 0 ins; 17 del; 0 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/ByteBufferArrayData.java

11 lines changed: 0 ins; 11 del; 0 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java

6 lines changed: 0 ins; 6 del; 0 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java

18 lines changed: 0 ins; 18 del; 0 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/FrozenArrayFilter.java

8 lines changed: 0 ins; 8 del; 0 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/IntArrayData.java

39 lines changed: 0 ins; 39 del; 0 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java

1 line changed: 0 ins; 0 del; 1 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/LengthNotWritableFilter.java

25 lines changed: 0 ins; 25 del; 0 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/NonExtensibleArrayFilter.java

8 lines changed: 0 ins; 8 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/NumberArrayData.java

13 lines changed: 0 ins; 12 del; 1 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java

12 lines changed: 0 ins; 12 del; 0 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java

31 lines changed: 0 ins; 31 del; 0 mod; 374 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/arrays/UndefinedArrayFilter.java

25 lines changed: 0 ins; 25 del; 0 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/linker/Bootstrap.java

19 lines changed: 0 ins; 18 del; 1 mod; 465 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java

3 lines changed: 1 ins; 0 del; 2 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/basic/JDK-8062799.js

21 lines changed: 0 ins; 21 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/basic/JDK-8062799.js.EXPECTED

18 lines changed: 0 ins; 18 del; 0 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/basic/JDK-8144131.js

7 lines changed: 0 ins; 6 del; 1 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/script/nosecurity/JDK-8067215.js

10 lines changed: 0 ins; 8 del; 2 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/NumberAccessTest.java

1 line changed: 0 ins; 0 del; 1 mod; 788 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/NumberBoxingTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 361 unchg

------ ------ ------ ------ --- New Patch Raw test/script/basic/JDK-8144020.js

126 lines changed: 126 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/src/jdk/nashorn/test/models/LongProvider.java

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk/nashorn/internal/runtime/arrays/LongArrayData.java

406 lines changed: 0 ins; 406 del; 0 mod; 0 unchg

This code review page was prepared using /home/hannes/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).