Code Review for open

Prepared by:iignatyev on Fri May 22 10:13:57 PDT 2020
Workspace:/Users/iignatye/ws/jdk/jdk-clean/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:59400
Summary of changes: 57482 lines changed: 80 ins; 57385 del; 17 mod; 4799 unchg
Changeset: open.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/Main.gmk

rev 59401 : [mq]: 8245610
2 lines changed: 0 ins; 0 del; 2 mod; 1295 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/RunTestsPrebuiltSpec.gmk

rev 59401 : [mq]: 8245610
1 line changed: 0 ins; 1 del; 0 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/autoconf/buildjdk-spec.gmk.in

rev 59401 : [mq]: 8245610
3 lines changed: 0 ins; 3 del; 0 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/autoconf/configure.ac

rev 59401 : [mq]: 8245610
1 line changed: 0 ins; 1 del; 0 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/autoconf/hotspot.m4

rev 59401 : [mq]: 8245610
25 lines changed: 3 ins; 22 del; 0 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/autoconf/lib-tests.m4

rev 59401 : [mq]: 8245610
rev 59403 : imported patch 8245610-copyright
34 lines changed: 33 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/autoconf/libraries.m4

rev 59401 : [mq]: 8245610
1 line changed: 1 ins; 0 del; 0 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/autoconf/spec.gmk.in

rev 59401 : [mq]: 8245610
5 lines changed: 2 ins; 3 del; 0 mod; 941 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/conf/jib-profiles.js

rev 59401 : [mq]: 8245610
18 lines changed: 6 ins; 0 del; 12 mod; 1371 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/hotspot/lib/CompileGtest.gmk

rev 59401 : [mq]: 8245610
42 lines changed: 35 ins; 6 del; 1 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/hotspot/lib/CompileLibraries.gmk

rev 59401 : [mq]: 8245610
1 line changed: 0 ins; 0 del; 1 mod; 43 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/CHANGES

rev 59402 : imported patch 8245610-removal
126 lines changed: 0 ins; 126 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/CONTRIBUTORS

rev 59402 : imported patch 8245610-removal
40 lines changed: 0 ins; 40 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/LICENSE

rev 59402 : imported patch 8245610-removal
28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/README.md

rev 59402 : imported patch 8245610-removal
322 lines changed: 0 ins; 322 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-actions.h

rev 59402 : imported patch 8245610-removal
1263 lines changed: 0 ins; 1263 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-cardinalities.h

rev 59402 : imported patch 8245610-removal
153 lines changed: 0 ins; 153 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-actions.h

rev 59402 : imported patch 8245610-removal
2567 lines changed: 0 ins; 2567 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-actions.h.pump

rev 59402 : imported patch 8245610-removal
833 lines changed: 0 ins; 833 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-function-mockers.h

rev 59402 : imported patch 8245610-removal
1380 lines changed: 0 ins; 1380 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-function-mockers.h.pump

rev 59402 : imported patch 8245610-removal
348 lines changed: 0 ins; 348 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-matchers.h

rev 59402 : imported patch 8245610-removal
2271 lines changed: 0 ins; 2271 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-matchers.h.pump

rev 59402 : imported patch 8245610-removal
679 lines changed: 0 ins; 679 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-nice-strict.h

rev 59402 : imported patch 8245610-removal
459 lines changed: 0 ins; 459 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-generated-nice-strict.h.pump

rev 59402 : imported patch 8245610-removal
179 lines changed: 0 ins; 179 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-matchers.h

rev 59402 : imported patch 8245610-removal
5288 lines changed: 0 ins; 5288 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-more-actions.h

rev 59402 : imported patch 8245610-removal
247 lines changed: 0 ins; 247 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-more-matchers.h

rev 59402 : imported patch 8245610-removal
92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock-spec-builders.h

rev 59402 : imported patch 8245610-removal
1918 lines changed: 0 ins; 1918 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/gmock.h

rev 59402 : imported patch 8245610-removal
96 lines changed: 0 ins; 96 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/custom/README.md

rev 59402 : imported patch 8245610-removal
16 lines changed: 0 ins; 16 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-generated-actions.h

rev 59402 : imported patch 8245610-removal
10 lines changed: 0 ins; 10 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-generated-actions.h.pump

rev 59402 : imported patch 8245610-removal
12 lines changed: 0 ins; 12 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-matchers.h

rev 59402 : imported patch 8245610-removal
36 lines changed: 0 ins; 36 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/custom/gmock-port.h

rev 59402 : imported patch 8245610-removal
39 lines changed: 0 ins; 39 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/gmock-generated-internal-utils.h

rev 59402 : imported patch 8245610-removal
287 lines changed: 0 ins; 287 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/gmock-generated-internal-utils.h.pump

rev 59402 : imported patch 8245610-removal
137 lines changed: 0 ins; 137 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/gmock-internal-utils.h

rev 59402 : imported patch 8245610-removal
575 lines changed: 0 ins; 575 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/include/gmock/internal/gmock-port.h

rev 59402 : imported patch 8245610-removal
88 lines changed: 0 ins; 88 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/src/gmock-all.cc

rev 59402 : imported patch 8245610-removal
46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/src/gmock-cardinalities.cc

rev 59402 : imported patch 8245610-removal
155 lines changed: 0 ins; 155 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/src/gmock-internal-utils.cc

rev 59402 : imported patch 8245610-removal
203 lines changed: 0 ins; 203 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/src/gmock-matchers.cc

rev 59402 : imported patch 8245610-removal
572 lines changed: 0 ins; 572 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/src/gmock-spec-builders.cc

rev 59402 : imported patch 8245610-removal
882 lines changed: 0 ins; 882 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/src/gmock.cc

rev 59402 : imported patch 8245610-removal
204 lines changed: 0 ins; 204 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googlemock/src/gmock_main.cc

rev 59402 : imported patch 8245610-removal
54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/CHANGES

rev 59402 : imported patch 8245610-removal
157 lines changed: 0 ins; 157 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/CONTRIBUTORS

rev 59402 : imported patch 8245610-removal
37 lines changed: 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/LICENSE

rev 59402 : imported patch 8245610-removal
28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/README.md

rev 59402 : imported patch 8245610-removal
345 lines changed: 0 ins; 345 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-death-test.h

rev 59402 : imported patch 8245610-removal
344 lines changed: 0 ins; 344 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-message.h

rev 59402 : imported patch 8245610-removal
255 lines changed: 0 ins; 255 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-param-test.h

rev 59402 : imported patch 8245610-removal
1434 lines changed: 0 ins; 1434 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-param-test.h.pump

rev 59402 : imported patch 8245610-removal
500 lines changed: 0 ins; 500 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-printers.h

rev 59402 : imported patch 8245610-removal
1111 lines changed: 0 ins; 1111 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-spi.h

rev 59402 : imported patch 8245610-removal
237 lines changed: 0 ins; 237 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-test-part.h

rev 59402 : imported patch 8245610-removal
183 lines changed: 0 ins; 183 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest-typed-test.h

rev 59402 : imported patch 8245610-removal
306 lines changed: 0 ins; 306 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest.h

rev 59402 : imported patch 8245610-removal
2346 lines changed: 0 ins; 2346 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest_pred_impl.h

rev 59402 : imported patch 8245610-removal
359 lines changed: 0 ins; 359 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/gtest_prod.h

rev 59402 : imported patch 8245610-removal
61 lines changed: 0 ins; 61 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/custom/README.md

rev 59402 : imported patch 8245610-removal
56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/custom/gtest-port.h

rev 59402 : imported patch 8245610-removal
37 lines changed: 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/custom/gtest-printers.h

rev 59402 : imported patch 8245610-removal
42 lines changed: 0 ins; 42 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/custom/gtest.h

rev 59402 : imported patch 8245610-removal
37 lines changed: 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-death-test-internal.h

rev 59402 : imported patch 8245610-removal
280 lines changed: 0 ins; 280 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-filepath.h

rev 59402 : imported patch 8245610-removal
211 lines changed: 0 ins; 211 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-internal.h

rev 59402 : imported patch 8245610-removal
1330 lines changed: 0 ins; 1330 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-linked_ptr.h

rev 59402 : imported patch 8245610-removal
243 lines changed: 0 ins; 243 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-param-util-generated.h

rev 59402 : imported patch 8245610-removal
5552 lines changed: 0 ins; 5552 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-param-util-generated.h.pump

rev 59402 : imported patch 8245610-removal
282 lines changed: 0 ins; 282 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-param-util.h

rev 59402 : imported patch 8245610-removal
724 lines changed: 0 ins; 724 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-port-arch.h

rev 59402 : imported patch 8245610-removal
100 lines changed: 0 ins; 100 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-port.h

rev 59402 : imported patch 8245610-removal
2711 lines changed: 0 ins; 2711 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-string.h

rev 59402 : imported patch 8245610-removal
167 lines changed: 0 ins; 167 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-tuple.h

rev 59402 : imported patch 8245610-removal
1021 lines changed: 0 ins; 1021 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-tuple.h.pump

rev 59402 : imported patch 8245610-removal
348 lines changed: 0 ins; 348 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-type-util.h

rev 59402 : imported patch 8245610-removal
3348 lines changed: 0 ins; 3348 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/include/gtest/internal/gtest-type-util.h.pump

rev 59402 : imported patch 8245610-removal
314 lines changed: 0 ins; 314 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-all.cc

rev 59402 : imported patch 8245610-removal
47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-death-test.cc

rev 59402 : imported patch 8245610-removal
1575 lines changed: 0 ins; 1575 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-filepath.cc

rev 59402 : imported patch 8245610-removal
385 lines changed: 0 ins; 385 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-internal-inl.h

rev 59402 : imported patch 8245610-removal
1187 lines changed: 0 ins; 1187 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-port.cc

rev 59402 : imported patch 8245610-removal
1318 lines changed: 0 ins; 1318 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-printers.cc

rev 59402 : imported patch 8245610-removal
457 lines changed: 0 ins; 457 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-test-part.cc

rev 59402 : imported patch 8245610-removal
101 lines changed: 0 ins; 101 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest-typed-test.cc

rev 59402 : imported patch 8245610-removal
118 lines changed: 0 ins; 118 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest.cc

rev 59402 : imported patch 8245610-removal
6013 lines changed: 0 ins; 6013 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/fmw/gtest/googletest/src/gtest_main.cc

rev 59402 : imported patch 8245610-removal
37 lines changed: 0 ins; 37 del; 0 mod; 0 unchg

This code review page was prepared using /Users/iignatye/ws/code-tools/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).