Code Review for open

Prepared by:mchung on Tue Dec 3 19:38:06 PST 2019
Workspace:/scratch/mchung/ws/valhalla/jdk-hidden-classes/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 3843 lines changed: 3288 ins; 200 del; 355 mod; 105165 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/hotspot/symbols/symbols-unix

2 lines changed: 2 ins; 0 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/aot/aotCodeHeap.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/aot/aotLoader.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciField.cpp

4 lines changed: 1 ins; 0 del; 3 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciInstanceKlass.cpp

5 lines changed: 2 ins; 0 del; 3 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciInstanceKlass.hpp

5 lines changed: 5 ins; 0 del; 0 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

156 lines changed: 107 ins; 26 del; 23 mod; 6292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.hpp

13 lines changed: 8 ins; 3 del; 2 mod; 536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.cpp

6 lines changed: 1 ins; 2 del; 3 mod; 1733 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

37 lines changed: 0 ins; 0 del; 37 mod; 938 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.hpp

12 lines changed: 0 ins; 0 del; 12 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataGraph.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 686 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataGraph.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderExt.cpp

4 lines changed: 1 ins; 2 del; 1 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp

8 lines changed: 0 ins; 0 del; 8 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderStats.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/defaultMethods.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

18 lines changed: 15 ins; 0 del; 3 mod; 4802 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.hpp

20 lines changed: 9 ins; 0 del; 11 mod; 1661 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/klassFactory.cpp

29 lines changed: 15 ins; 2 del; 12 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/klassFactory.hpp

4 lines changed: 1 ins; 2 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/moduleEntry.hpp

1 line changed: 0 ins; 0 del; 1 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

83 lines changed: 56 ins; 9 del; 18 mod; 2843 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.hpp

66 lines changed: 47 ins; 18 del; 1 mod; 637 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionaryShared.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 1491 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

1 line changed: 1 ins; 0 del; 0 mod; 1087 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

3 lines changed: 3 ins; 0 del; 0 mod; 1690 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/include/jvm.h

19 lines changed: 19 ins; 0 del; 0 mod; 1294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp

6 lines changed: 3 ins; 0 del; 3 mod; 1566 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp

3 lines changed: 0 ins; 2 del; 1 mod; 944 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp

1 line changed: 0 ins; 0 del; 1 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.cpp

7 lines changed: 0 ins; 0 del; 7 mod; 521 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceTracer.cpp

1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/arrayKlass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

90 lines changed: 82 ins; 0 del; 8 mod; 4056 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

11 lines changed: 5 ins; 0 del; 6 mod; 1451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceMirrorKlass.inline.hpp

4 lines changed: 0 ins; 1 del; 3 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

14 lines changed: 13 ins; 0 del; 1 mod; 965 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 705 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.hpp

3 lines changed: 1 ins; 0 del; 2 mod; 1204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2compiler.cpp

1 line changed: 1 ins; 0 del; 0 mod; 656 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

18 lines changed: 18 ins; 0 del; 0 mod; 6889 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

181 lines changed: 178 ins; 0 del; 3 mod; 3641 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRedefineClasses.cpp

9 lines changed: 4 ins; 1 del; 4 mod; 4340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/methodHandles.cpp

17 lines changed: 16 ins; 0 del; 1 mod; 1613 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/unsafe.cpp

12 lines changed: 9 ins; 2 del; 1 mod; 1150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/reflection.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 3199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/accessFlags.hpp

3 lines changed: 3 ins; 0 del; 0 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

83 lines changed: 61 ins; 9 del; 13 mod; 4095 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ClassLoader.java

23 lines changed: 23 ins; 0 del; 0 mod; 3060 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/StringConcatHelper.java

13 lines changed: 13 ins; 0 del; 0 mod; 469 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/System.java

15 lines changed: 15 ins; 0 del; 0 mod; 2287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java

16 lines changed: 15 ins; 1 del; 0 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/GenerateJLIClassesHelper.java

13 lines changed: 3 ins; 7 del; 3 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java

58 lines changed: 12 ins; 35 del; 11 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java

130 lines changed: 85 ins; 13 del; 32 mod; 1862 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java

20 lines changed: 11 ins; 6 del; 3 mod; 2258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java

12 lines changed: 12 ins; 0 del; 0 mod; 662 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandles.java

338 lines changed: 290 ins; 14 del; 34 mod; 6718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java

50 lines changed: 12 ins; 16 del; 22 mod; 1878 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java

20 lines changed: 20 ins; 0 del; 0 mod; 322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java

4 lines changed: 3 ins; 1 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/NativeMethodAccessorImpl.java

4 lines changed: 3 ins; 1 del; 0 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java

3 lines changed: 1 ins; 0 del; 2 mod; 686 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/Class.c

1 line changed: 1 ins; 0 del; 0 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/ClassLoader.c

60 lines changed: 60 ins; 0 del; 0 mod; 519 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java

2 lines changed: 0 ins; 2 del; 0 mod; 2418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

12 lines changed: 0 ins; 12 del; 0 mod; 2419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java

4 lines changed: 0 ins; 0 del; 4 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/Context.java

72 lines changed: 62 ins; 3 del; 7 mod; 1793 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/ScriptLoader.java

2 lines changed: 1 ins; 0 del; 1 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.unsupported/share/classes/sun/misc/Unsafe.java

6 lines changed: 6 ins; 0 del; 0 mod; 1237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_metaspace_allocation.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/ProblemList.txt

6 lines changed: 6 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/Synthetic/BridgeMethodsForLambdaTest.java

9 lines changed: 0 ins; 4 del; 5 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/bytecode/TestLambdaBytecode.java

2 lines changed: 0 ins; 0 del; 2 mod; 303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/lambdaExpression/LambdaTest6.java

3 lines changed: 0 ins; 3 del; 0 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/methodReference/BridgeMethod.java

3 lines changed: 0 ins; 3 del; 0 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames --- New Patch --- test/jdk/java/lang/invoke/defineHiddenClass/DefineClassWithClassData.java

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/HiddenClasses/DefineHiddenClass.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/HiddenClasses/hidden/NameInString.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/OtherPackage.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/Nestmates/membership/TestDynamicNestmateMembership.java

162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java

356 lines changed: 356 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/HiddenNestmateTest.java

182 lines changed: 182 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/LambdaNestedInnerTest.java

150 lines changed: 150 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/SelfRefField.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/SelfRefMethod.java

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/SelfReferenceDescriptor.java

102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/AbstractClass.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/EnclosingClass.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/HiddenCantReflect.java

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/HiddenClass.java

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/HiddenClassThrow.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/HiddenInterface.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/HiddenSuper.java

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/Lambda.java

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/defineHiddenClass/src/Outer.java

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/lambda/superProtectedMethod/SuperMethodTest.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/lambda/superProtectedMethod/q/I.java

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/lang/invoke/lambda/superProtectedMethod/q/J.java

39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/micro/org/openjdk/bench/java/lang/invoke/LookupDefineClass.java

288 lines changed: 288 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/devtools/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).