Code Review for jdk

Prepared by:sherman on Thu Jul 18 10:21:44 PDT 2013
Workspace:/export/sherman/Workspace/jdk8_tl_310/jdk
Summary of changes: 8501 lines changed: 6630 ins; 813 del; 1058 mod; 71799 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/DayOfWeek.java

3 lines changed: 1 ins; 1 del; 1 mod; 449 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/Duration.java

3 lines changed: 0 ins; 0 del; 3 mod; 1331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/Instant.java

50 lines changed: 40 ins; 0 del; 10 mod; 1302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/LocalDate.java

53 lines changed: 36 ins; 0 del; 17 mod; 2004 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/LocalDateTime.java

53 lines changed: 43 ins; 1 del; 9 mod; 1936 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/LocalTime.java

49 lines changed: 38 ins; 1 del; 10 mod; 1633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/Month.java

3 lines changed: 1 ins; 1 del; 1 mod; 611 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/MonthDay.java

1 line changed: 0 ins; 0 del; 1 mod; 779 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/OffsetDateTime.java

86 lines changed: 62 ins; 6 del; 18 mod; 1857 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/OffsetTime.java

44 lines changed: 38 ins; 0 del; 6 mod; 1364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/Period.java

49 lines changed: 32 ins; 0 del; 17 mod; 982 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/Year.java

49 lines changed: 40 ins; 0 del; 9 mod; 1063 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/YearMonth.java

51 lines changed: 42 ins; 0 del; 9 mod; 1190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/ZoneId.java

33 lines changed: 30 ins; 0 del; 3 mod; 663 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/ZoneOffset.java

4 lines changed: 1 ins; 1 del; 2 mod; 784 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/ZoneRegion.java

14 lines changed: 0 ins; 14 del; 0 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/ZonedDateTime.java

54 lines changed: 43 ins; 2 del; 9 mod; 2178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ChronoDateImpl.java

72 lines changed: 57 ins; 0 del; 15 mod; 383 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ChronoLocalDate.java

76 lines changed: 46 ins; 1 del; 29 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ChronoLocalDateTime.java

53 lines changed: 47 ins; 0 del; 6 mod; 536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java

37 lines changed: 18 ins; 1 del; 18 mod; 415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ChronoZonedDateTime.java

53 lines changed: 47 ins; 0 del; 6 mod; 611 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java

29 lines changed: 20 ins; 1 del; 8 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/Chronology.java

367 lines changed: 236 ins; 100 del; 31 mod; 1023 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/Era.java

1 line changed: 0 ins; 0 del; 1 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/HijrahChronology.java

25 lines changed: 19 ins; 0 del; 6 mod; 1051 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/HijrahDate.java

12 lines changed: 1 ins; 0 del; 11 mod; 622 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/IsoChronology.java

150 lines changed: 6 ins; 137 del; 7 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/JapaneseChronology.java

199 lines changed: 147 ins; 35 del; 17 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/JapaneseDate.java

182 lines changed: 105 ins; 49 del; 28 mod; 577 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/JapaneseEra.java

44 lines changed: 4 ins; 20 del; 20 mod; 363 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/MinguoChronology.java

13 lines changed: 12 ins; 0 del; 1 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/MinguoDate.java

19 lines changed: 6 ins; 5 del; 8 mod; 455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ThaiBuddhistChronology.java

13 lines changed: 12 ins; 0 del; 1 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/ThaiBuddhistDate.java

8 lines changed: 1 ins; 0 del; 7 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/chrono/package-info.java

4 lines changed: 0 ins; 0 del; 4 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/format/DateTimeFormatter.java

2 lines changed: 0 ins; 0 del; 2 mod; 2158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/format/DateTimeFormatterBuilder.java

80 lines changed: 33 ins; 14 del; 33 mod; 4356 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/format/DateTimePrintContext.java

1 line changed: 0 ins; 0 del; 1 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/format/Parsed.java

29 lines changed: 5 ins; 13 del; 11 mod; 554 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/ChronoField.java

19 lines changed: 6 ins; 7 del; 6 mod; 741 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/ChronoUnit.java

33 lines changed: 8 ins; 18 del; 7 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/IsoFields.java

83 lines changed: 30 ins; 19 del; 34 mod; 640 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/JulianFields.java

22 lines changed: 10 ins; 8 del; 4 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/Temporal.java

32 lines changed: 25 ins; 1 del; 6 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/TemporalAccessor.java

17 lines changed: 8 ins; 1 del; 8 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/TemporalField.java

97 lines changed: 44 ins; 21 del; 32 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/TemporalUnit.java

55 lines changed: 42 ins; 9 del; 4 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/ValueRange.java

1 line changed: 0 ins; 0 del; 1 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/time/temporal/WeekFields.java

240 lines changed: 178 ins; 36 del; 26 mod; 932 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/lib/hijrah-config-umalqura.properties

369 lines changed: 311 ins; 0 del; 58 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/MockSimplePeriod.java

1 line changed: 0 ins; 0 del; 1 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKClock_Fixed.java

1 line changed: 1 ins; 0 del; 0 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKDayOfWeek.java

38 lines changed: 38 ins; 0 del; 0 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKInstant.java

38 lines changed: 24 ins; 8 del; 6 mod; 2113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKLocalDate.java

74 lines changed: 62 ins; 0 del; 12 mod; 2216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKLocalDateTime.java

67 lines changed: 62 ins; 0 del; 5 mod; 3224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKLocalTime.java

100 lines changed: 86 ins; 8 del; 6 mod; 2284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKMonth.java

38 lines changed: 38 ins; 0 del; 0 mod; 478 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKMonthDay.java

38 lines changed: 38 ins; 0 del; 0 mod; 787 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKOffsetDateTime.java

77 lines changed: 77 ins; 0 del; 0 mod; 1495 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKOffsetTime.java

67 lines changed: 62 ins; 0 del; 5 mod; 1390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKPeriod.java

37 lines changed: 36 ins; 0 del; 1 mod; 1135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKYear.java

68 lines changed: 62 ins; 0 del; 6 mod; 1099 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKYearMonth.java

68 lines changed: 62 ins; 0 del; 6 mod; 1452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKZoneId.java

47 lines changed: 47 ins; 0 del; 0 mod; 696 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/TCKZonedDateTime.java

96 lines changed: 66 ins; 0 del; 30 mod; 2379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/CopticDate.java

9 lines changed: 0 ins; 0 del; 9 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKChronoLocalDate.java

69 lines changed: 30 ins; 10 del; 29 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKChronoLocalDateTime.java

40 lines changed: 30 ins; 10 del; 0 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKChronoZonedDateTime.java

42 lines changed: 31 ins; 10 del; 1 mod; 487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKChronology.java

128 lines changed: 124 ins; 0 del; 4 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKHijrahChronology.java

396 lines changed: 266 ins; 61 del; 69 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKHijrahEra.java

2 lines changed: 2 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKIsoChronology.java

123 lines changed: 54 ins; 52 del; 17 mod; 610 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKJapaneseChronology.java

729 lines changed: 638 ins; 36 del; 55 mod; 485 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKJapaneseEra.java

3 lines changed: 0 ins; 1 del; 2 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKMinguoChronology.java

443 lines changed: 437 ins; 0 del; 6 mod; 517 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/chrono/TCKThaiBuddhistChronology.java

477 lines changed: 434 ins; 0 del; 43 mod; 457 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/format/TCKTextStyle.java

10 lines changed: 10 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/format/TCKZoneIdPrinterParser.java

65 lines changed: 13 ins; 3 del; 49 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/temporal/TCKWeekFields.java

268 lines changed: 234 ins; 8 del; 26 mod; 556 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/tck/java/time/zone/TCKZoneRules.java

136 lines changed: 136 ins; 0 del; 0 mod; 1005 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/MockSimplePeriod.java

1 line changed: 0 ins; 0 del; 1 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/chrono/TestChronoLocalDate.java

88 lines changed: 22 ins; 53 del; 13 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/chrono/TestExampleCode.java

35 lines changed: 26 ins; 0 del; 9 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/chrono/TestJapaneseChronoImpl.java

32 lines changed: 31 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/chrono/TestJapaneseChronology.java

11 lines changed: 1 ins; 8 del; 2 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java

617 lines changed: 560 ins; 17 del; 40 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/format/TestDateTimeTextProvider.java

12 lines changed: 0 ins; 0 del; 12 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/format/TestNonIsoFormatter.java

3 lines changed: 0 ins; 0 del; 3 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/format/TestNumberPrinter.java

5 lines changed: 0 ins; 0 del; 5 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/format/TestReducedPrinter.java

1 line changed: 0 ins; 0 del; 1 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/temporal/MockFieldNoValue.java

20 lines changed: 15 ins; 5 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/time/test/java/time/temporal/MockFieldValue.java

1 line changed: 0 ins; 0 del; 1 mod; 104 unchg

------ ------ ------ ------ --- New Patch Raw test/java/time/tck/java/time/format/TCKFormatStyle.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/time/tck/java/time/format/TCKResolverStyle.java

139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/time/tck/java/time/format/TCKSignStyle.java

137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/time/tck/java/time/temporal/TCKChronoField.java

268 lines changed: 268 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/time/tck/java/time/temporal/TCKChronoUnit.java

187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/devtools/share/bin/webrev (vers 23.18-hg+jbs).