Code Review for open

Prepared by:stefank on Fri Apr 27 15:30:14 CEST 2018
Workspace:/home/stefank/hg/jdk/hs/open
Compare against version:-2
Summary of changes: 664 lines changed: 325 ins; 74 del; 265 mod; 74577 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1596 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/interp_masm_arm.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 2069 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/macroAssembler_arm.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 3256 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/macroAssembler_arm.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 1409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1979 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/templateTable_arm.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 5024 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/zero/cppInterpreterGenerator_zero.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/aot/aotCodeHeap.cpp

6 lines changed: 5 ins; 1 del; 0 mod; 1052 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/abstractCompiler.cpp

1 line changed: 0 ins; 1 del; 0 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.hpp

1 line changed: 1 ins; 0 del; 0 mod; 867 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp

5 lines changed: 0 ins; 0 del; 5 mod; 718 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psOldGen.cpp

8 lines changed: 7 ins; 0 del; 1 mod; 489 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psOldGen.hpp

6 lines changed: 6 ins; 0 del; 0 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psScavenge.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 782 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psYoungGen.cpp

4 lines changed: 4 ins; 0 del; 0 mod; 901 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psYoungGen.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/defNewGeneration.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/tenuredGeneration.cpp

1 line changed: 0 ins; 0 del; 1 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/vmStructs_serial.hpp

10 lines changed: 9 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/barrierSetConfig.hpp

5 lines changed: 0 ins; 4 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/barrierSetConfig.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/blockOffsetTable.hpp

4 lines changed: 1 ins; 1 del; 2 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectorPolicy.hpp

3 lines changed: 0 ins; 3 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcConfig.cpp

41 lines changed: 16 ins; 8 del; 17 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcTrace.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcTrace.hpp

5 lines changed: 0 ins; 0 del; 5 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcTraceSend.cpp

5 lines changed: 1 ins; 1 del; 3 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gc_globals.hpp

14 lines changed: 7 ins; 1 del; 6 mod; 764 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 1421 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 517 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genMemoryPools.cpp

8 lines changed: 7 ins; 1 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genOopClosures.cpp

6 lines changed: 5 ins; 1 del; 0 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genOopClosures.hpp

7 lines changed: 7 ins; 0 del; 0 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genOopClosures.inline.hpp

12 lines changed: 11 ins; 1 del; 0 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/generation.cpp

5 lines changed: 4 ins; 1 del; 0 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/generation.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 572 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/generationSpec.cpp

12 lines changed: 6 ins; 2 del; 4 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp

32 lines changed: 12 ins; 1 del; 19 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/jvmFlagConstraintsGC.hpp

5 lines changed: 4 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.cpp

10 lines changed: 7 ins; 1 del; 2 mod; 766 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.hpp

10 lines changed: 8 ins; 0 del; 2 mod; 784 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.inline.hpp

8 lines changed: 7 ins; 1 del; 0 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/specialized_oop_closures.hpp

17 lines changed: 5 ins; 1 del; 11 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/vmGCOperations.cpp

5 lines changed: 2 ins; 0 del; 3 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/vmStructs_gc.hpp

51 lines changed: 8 ins; 10 del; 33 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciRuntime.cpp

10 lines changed: 4 ins; 4 del; 2 mod; 925 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciRuntime.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

8 lines changed: 0 ins; 1 del; 7 mod; 988 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/arrayKlass.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceClassLoaderKlass.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceClassLoaderKlass.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 1509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.inline.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceMirrorKlass.hpp

4 lines changed: 0 ins; 0 del; 4 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceMirrorKlass.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceRefKlass.hpp

5 lines changed: 0 ins; 0 del; 5 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceRefKlass.inline.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.hpp

6 lines changed: 0 ins; 0 del; 6 mod; 754 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/objArrayKlass.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.cpp

1 line changed: 0 ins; 0 del; 1 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.hpp

5 lines changed: 0 ins; 2 del; 3 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.inline.hpp

6 lines changed: 0 ins; 2 del; 4 mod; 504 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/typeArrayKlass.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/arraycopynode.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

4 lines changed: 2 ins; 0 del; 2 mod; 4646 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.cpp

4 lines changed: 2 ins; 0 del; 2 mod; 3535 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/graphKit.cpp

16 lines changed: 12 ins; 3 del; 1 mod; 4533 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/graphKit.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 967 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/macro.cpp

6 lines changed: 3 ins; 0 del; 3 mod; 2799 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 1665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/precompiled/precompiled.hpp

8 lines changed: 2 ins; 2 del; 4 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

35 lines changed: 17 ins; 7 del; 11 mod; 2149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/init.cpp

4 lines changed: 2 ins; 0 del; 2 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/mutexLocker.cpp

2 lines changed: 0 ins; 2 del; 0 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 3151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 721 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

6 lines changed: 0 ins; 2 del; 4 mod; 5024 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/hashtable.cpp

4 lines changed: 0 ins; 4 del; 0 mod; 487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/macros.hpp

80 lines changed: 59 ins; 0 del; 21 mod; 520 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/parallel/test_psAdaptiveSizePolicy.cpp

3 lines changed: 1 ins; 1 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp

7 lines changed: 2 ins; 4 del; 1 mod; 94 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/parallel/psMarkSweepProxy.hpp

53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).