Code Review for source

Prepared by:stuefe stuefe on Fri Aug 2 08:07:50 CEST 2019
Workspace:/shared/projects/openjdk/jdk-sandbox/source
Compare against: https://hg.openjdk.java.net/jdk/sandbox
Compare against version:57600
Summary of changes: 9039 lines changed: 4310 ins; 3764 del; 965 mod; 28934 unchg
Patch of changes: source.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.cpp

rev 57601 : [mq]: metaspace-improvement
11 lines changed: 6 ins; 0 del; 5 mod; 971 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderData.hpp

rev 57601 : [mq]: metaspace-improvement
8 lines changed: 4 ins; 1 del; 3 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataGraph.cpp

rev 57601 : [mq]: metaspace-improvement
18 lines changed: 0 ins; 18 del; 0 mod; 707 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderDataGraph.hpp

rev 57601 : [mq]: metaspace-improvement
8 lines changed: 0 ins; 8 del; 0 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderStats.cpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 4783 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psMarkSweep.cpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 661 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 3155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 57601 : [mq]: metaspace-improvement
10 lines changed: 1 ins; 0 del; 9 mod; 581 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.hpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcTrace.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 1 ins; 0 del; 2 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcTrace.hpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 0 ins; 0 del; 2 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcTraceSend.cpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 473 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcVMOperations.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 2 ins; 0 del; 1 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcVMOperations.hpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 1 ins; 0 del; 2 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 1408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 57601 : [mq]: metaspace-improvement
5 lines changed: 2 ins; 1 del; 2 mod; 2909 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 722 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zCollectedHeap.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 2 ins; 0 del; 1 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zCollectedHeap.hpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zUnload.cpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp

rev 57601 : [mq]: metaspace-improvement
4 lines changed: 1 ins; 0 del; 3 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metadataFactory.hpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 2 ins; 0 del; 0 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

rev 57601 : [mq]: metaspace-improvement
1144 lines changed: 186 ins; 894 del; 64 mod; 708 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.hpp

rev 57601 : [mq]: metaspace-improvement
345 lines changed: 67 ins; 248 del; 30 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.cpp

rev 57601 : [mq]: metaspace-improvement
629 lines changed: 90 ins; 435 del; 104 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/chunkManager.hpp

rev 57601 : [mq]: metaspace-improvement
208 lines changed: 53 ins; 109 del; 46 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.cpp

rev 57601 : [mq]: metaspace-improvement
195 lines changed: 77 ins; 80 del; 38 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metachunk.hpp

rev 57601 : [mq]: metaspace-improvement
227 lines changed: 106 ins; 43 del; 78 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.cpp

rev 57601 : [mq]: metaspace-improvement
109 lines changed: 23 ins; 65 del; 21 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceCommon.hpp

rev 57601 : [mq]: metaspace-improvement
50 lines changed: 0 ins; 50 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceDCmd.cpp

rev 57601 : [mq]: metaspace-improvement
7 lines changed: 0 ins; 0 del; 7 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceSizesSnapshot.cpp

rev 57601 : [mq]: metaspace-improvement
5 lines changed: 1 ins; 0 del; 4 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.cpp

rev 57601 : [mq]: metaspace-improvement
140 lines changed: 15 ins; 81 del; 44 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/metaspaceStatistics.hpp

rev 57601 : [mq]: metaspace-improvement
108 lines changed: 14 ins; 64 del; 30 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.cpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.hpp

rev 57601 : [mq]: metaspace-improvement
5 lines changed: 1 ins; 0 del; 4 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.cpp

rev 57601 : [mq]: metaspace-improvement
426 lines changed: 22 ins; 300 del; 104 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/spaceManager.hpp

rev 57601 : [mq]: metaspace-improvement
176 lines changed: 13 ins; 134 del; 29 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.cpp

rev 57601 : [mq]: metaspace-improvement
415 lines changed: 40 ins; 300 del; 75 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.hpp

rev 57601 : [mq]: metaspace-improvement
112 lines changed: 13 ins; 57 del; 42 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp

rev 57601 : [mq]: metaspace-improvement
620 lines changed: 148 ins; 368 del; 104 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp

rev 57601 : [mq]: metaspace-improvement
256 lines changed: 155 ins; 77 del; 24 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceChunkFreeListSummary.hpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 1 ins; 0 del; 0 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceCounters.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 0 ins; 0 del; 3 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceTracer.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 0 ins; 0 del; 3 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceTracer.hpp

rev 57601 : [mq]: metaspace-improvement
4 lines changed: 0 ins; 0 del; 4 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/universe.cpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 1244 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmOperations.cpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memReporter.cpp

rev 57601 : [mq]: metaspace-improvement
36 lines changed: 2 ins; 2 del; 32 mod; 769 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memReporter.hpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 0 ins; 0 del; 3 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryPool.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 1 ins; 0 del; 2 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/virtualMemoryTracker.cpp

rev 57601 : [mq]: metaspace-improvement
8 lines changed: 0 ins; 0 del; 8 mod; 625 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/virtualMemoryTracker.hpp

rev 57601 : [mq]: metaspace-improvement
12 lines changed: 0 ins; 0 del; 12 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.cpp

rev 57601 : [mq]: metaspace-improvement
1 line changed: 0 ins; 0 del; 1 mod; 701 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.hpp

rev 57601 : [mq]: metaspace-improvement
7 lines changed: 4 ins; 0 del; 3 mod; 446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_chunkManager.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 2 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_is_metaspace_obj.cpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 2 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_metachunk.cpp

rev 57601 : [mq]: metaspace-improvement
4 lines changed: 4 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_metaspace.cpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_metaspace_allocation.cpp

rev 57601 : [mq]: metaspace-improvement
3 lines changed: 3 ins; 0 del; 0 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_spaceManager.cpp

rev 57601 : [mq]: metaspace-improvement
2 lines changed: 1 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/memory/test_virtualspace.cpp

rev 57601 : [mq]: metaspace-improvement
6 lines changed: 6 ins; 0 del; 0 mod; 339 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/abstractPool.hpp

rev 57601 : [mq]: metaspace-improvement
210 lines changed: 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkAllocSequence.cpp

rev 57601 : [mq]: metaspace-improvement
190 lines changed: 190 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkAllocSequence.hpp

rev 57601 : [mq]: metaspace-improvement
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkLevel.cpp

rev 57601 : [mq]: metaspace-improvement
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkLevel.hpp

rev 57601 : [mq]: metaspace-improvement
122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkTree.cpp

rev 57601 : [mq]: metaspace-improvement
514 lines changed: 514 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/chunkTree.hpp

rev 57601 : [mq]: metaspace-improvement
280 lines changed: 280 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/classLoaderMetaspace.cpp

rev 57601 : [mq]: metaspace-improvement
149 lines changed: 149 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/classLoaderMetaspace.hpp

rev 57601 : [mq]: metaspace-improvement
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitLimiter.cpp

rev 57601 : [mq]: metaspace-improvement
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitLimiter.hpp

rev 57601 : [mq]: metaspace-improvement
61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitMask.cpp

rev 57601 : [mq]: metaspace-improvement
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/commitMask.hpp

rev 57601 : [mq]: metaspace-improvement
189 lines changed: 189 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/constants.hpp

rev 57601 : [mq]: metaspace-improvement
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/counter.hpp

rev 57601 : [mq]: metaspace-improvement
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceEnums.cpp

rev 57601 : [mq]: metaspace-improvement
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceEnums.hpp

rev 57601 : [mq]: metaspace-improvement
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceReport.cpp

rev 57601 : [mq]: metaspace-improvement
400 lines changed: 400 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/metaspaceReport.hpp

rev 57601 : [mq]: metaspace-improvement
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/runningCounters.cpp

rev 57601 : [mq]: metaspace-improvement
98 lines changed: 98 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/memory/metaspace/runningCounters.hpp

rev 57601 : [mq]: metaspace-improvement
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/gtest/metaspace/test_pool.cpp

rev 57601 : [mq]: metaspace-improvement
248 lines changed: 248 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/memory/metaspace/occupancyMap.cpp

rev 57601 : [mq]: metaspace-improvement
135 lines changed: 0 ins; 135 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/memory/metaspace/occupancyMap.hpp

rev 57601 : [mq]: metaspace-improvement
242 lines changed: 0 ins; 242 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/memory/metaspaceGCThresholdUpdater.hpp

rev 57601 : [mq]: metaspace-improvement
52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

This code review page was prepared using /shared/projects/openjdk/code-tools/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).