Code Review for openjdk

Prepared by: Thomas Schatzl (tschatzl) on Wed Nov 6 20:19:19 CET 2019
Workspace:/home/tschatzl/Downloads/openjdk
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:-3
Summary of changes: 436 lines changed: 150 ins; 136 del; 150 mod; 24366 unchg
Patch of changes: openjdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/aot/aotCodeHeap.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 1 ins; 0 del; 0 mod; 1105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 3140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 1445 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1BlockOffsetTable.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
23 lines changed: 0 ins; 2 del; 21 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
5 lines changed: 0 ins; 0 del; 5 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
7 lines changed: 0 ins; 1 del; 6 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
3 lines changed: 0 ins; 2 del; 1 mod; 4762 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.hpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 1 ins; 0 del; 0 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1YoungGenSizer.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 1 ins; 0 del; 0 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
88 lines changed: 23 ins; 45 del; 20 mod; 833 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.hpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
147 lines changed: 35 ins; 77 del; 35 mod; 626 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.inline.hpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
26 lines changed: 1 ins; 3 del; 22 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/vmStructs_g1.hpp

rev 56812 : imported patch 8189737-stefanj-review
8 lines changed: 4 ins; 2 del; 2 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/asPSYoungGen.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/mutableSpace.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psMarkSweep.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 659 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psMarkSweepDecorator.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psOldGen.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 3357 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psScavenge.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 859 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psYoungGen.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 896 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/defNewGeneration.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 996 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/generation.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 0 ins; 0 del; 1 mod; 724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/spaceDecorator.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
2 lines changed: 1 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/spaceDecorator.hpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
7 lines changed: 1 ins; 0 del; 6 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/G1CollectedHeap.java

rev 56812 : imported patch 8189737-stefanj-review
6 lines changed: 2 ins; 2 del; 2 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegion.java

rev 56812 : imported patch 8189737-stefanj-review
19 lines changed: 11 ins; 2 del; 6 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/g1/test_g1HeapVerifier.cpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
1 line changed: 1 ins; 0 del; 0 mod; 84 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/spaceDecorator.inline.hpp

rev 56811 : imported patch 8189737-heapregion-remove-space-inheritance
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegionClosure.java

rev 56812 : imported patch 8189737-stefanj-review
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/PrintRegionClosure.java (was src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/PrintRegionClosure.java)

rev 56812 : imported patch 8189737-stefanj-review
10 lines changed: 0 ins; 0 del; 10 mod; 30 unchg

This code review page was prepared using ../webrev.ksh (vers 25.17-hg+openjdk.java.net).