Code Review for jdk

Prepared by: Jenkins user (jenkins) on Tue Mar 21 13:44:44 UTC 2017
Workspace:/scratch/jenkins/jobs/jake-webrevs/workspace/jdk
Compare against: http://hg.openjdk.java.net/jigsaw/jake/jdk
Compare against version:jdk-9+161
Summary of changes: 4442 lines changed: 2998 ins; 832 del; 612 mod; 64956 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libjava/mapfile-vers

1 line changed: 0 ins; 1 del; 0 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

6 lines changed: 1 ins; 1 del; 4 mod; 3816 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ClassLoader.java

7 lines changed: 0 ins; 0 del; 7 mod; 2890 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/RuntimePermission.java

22 lines changed: 18 ins; 2 del; 2 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/StackStreamFactory.java

7 lines changed: 0 ins; 7 del; 0 mod; 993 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/System.java

52 lines changed: 49 ins; 0 del; 3 mod; 2054 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandles.java

119 lines changed: 118 ins; 0 del; 1 mod; 5764 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/Configuration.java

19 lines changed: 6 ins; 11 del; 2 mod; 561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/ModuleDescriptor.java

239 lines changed: 72 ins; 135 del; 32 mod; 2630 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/ModuleFinder.java

46 lines changed: 28 ins; 7 del; 11 mod; 377 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/ModuleReader.java

12 lines changed: 9 ins; 0 del; 3 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/module/Resolver.java

82 lines changed: 31 ins; 29 del; 22 mod; 883 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/AccessibleObject.java

118 lines changed: 54 ins; 27 del; 37 mod; 583 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Constructor.java

15 lines changed: 15 ins; 0 del; 0 mod; 640 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Field.java

5 lines changed: 5 ins; 0 del; 0 mod; 1196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Layer.java

57 lines changed: 36 ins; 6 del; 15 mod; 898 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Method.java

16 lines changed: 16 ins; 0 del; 0 mod; 709 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Module.java

108 lines changed: 43 ins; 35 del; 30 mod; 1518 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Proxy.java

43 lines changed: 13 ins; 3 del; 27 mod; 1079 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/ServiceLoader.java

6 lines changed: 3 ins; 0 del; 3 mod; 1629 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jmod/JmodFile.java

14 lines changed: 7 ins; 1 del; 6 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java

5 lines changed: 0 ins; 2 del; 3 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/loader/BootLoader.java

16 lines changed: 8 ins; 8 del; 0 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java

39 lines changed: 19 ins; 8 del; 12 mod; 976 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/loader/Loader.java

30 lines changed: 10 ins; 2 del; 18 mod; 636 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaLangAccess.java

6 lines changed: 6 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaLangModuleAccess.java

4 lines changed: 0 ins; 3 del; 1 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaLangReflectModuleAccess.java

25 lines changed: 1 ins; 14 del; 10 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/Builder.java

30 lines changed: 0 ins; 30 del; 0 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/Checks.java

35 lines changed: 5 ins; 8 del; 22 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ClassFileAttributes.java

32 lines changed: 8 ins; 15 del; 9 mod; 767 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java

38 lines changed: 23 ins; 5 del; 10 mod; 745 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleInfo.java

44 lines changed: 21 ins; 9 del; 14 mod; 1057 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java

7 lines changed: 0 ins; 4 del; 3 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java

24 lines changed: 12 ins; 3 del; 9 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModulePatcher.java

31 lines changed: 6 ins; 10 del; 15 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModulePath.java

18 lines changed: 0 ins; 1 del; 17 mod; 716 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleReferenceImpl.java

12 lines changed: 12 ins; 0 del; 0 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleReferences.java

35 lines changed: 5 ins; 23 del; 7 mod; 419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/Modules.java

58 lines changed: 5 ins; 29 del; 24 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/SystemModuleFinder.java

14 lines changed: 11 ins; 0 del; 3 mod; 455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/SystemModules.java

12 lines changed: 9 ins; 0 del; 3 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

1 line changed: 0 ins; 0 del; 1 mod; 2571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/Reflection.java

101 lines changed: 12 ins; 70 del; 19 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java

13 lines changed: 1 ins; 7 del; 5 mod; 631 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/module-info.java

13 lines changed: 1 ins; 7 del; 5 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/launcher/LauncherHelper.java

24 lines changed: 20 ins; 0 del; 4 mod; 1043 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/launcher/resources/launcher.properties

17 lines changed: 9 ins; 4 del; 4 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java

15 lines changed: 0 ins; 12 del; 3 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/ClassLoader.c

17 lines changed: 2 ins; 15 del; 0 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/libjava/Module.c

13 lines changed: 4 ins; 2 del; 7 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.instrument/share/classes/java/lang/instrument/ClassFileTransformer.java

3 lines changed: 3 ins; 0 del; 0 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jartool/share/classes/sun/tools/jar/Main.java

10 lines changed: 5 ins; 0 del; 5 mod; 2034 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java

10 lines changed: 0 ins; 8 del; 2 mod; 587 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java

26 lines changed: 23 ins; 2 del; 1 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java

8 lines changed: 0 ins; 8 del; 0 mod; 596 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolConfiguration.java

3 lines changed: 0 ins; 3 del; 0 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolManager.java

34 lines changed: 25 ins; 2 del; 7 mod; 458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ExcludeVMPlugin.java

1 line changed: 0 ins; 0 del; 1 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java

8 lines changed: 3 ins; 5 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java

93 lines changed: 54 ins; 27 del; 12 mod; 1401 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/plugin/ResourcePoolModule.java

15 lines changed: 15 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java

30 lines changed: 9 ins; 10 del; 11 mod; 1522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod.properties

2 lines changed: 0 ins; 2 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.unsupported/share/classes/sun/misc/Unsafe.java

1 line changed: 1 ins; 0 del; 0 mod; 1257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/AutomaticModulesTest.java

3 lines changed: 0 ins; 3 del; 0 mod; 877 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ConfigurationTest.java

259 lines changed: 107 ins; 121 del; 31 mod; 1998 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ModuleDescriptorTest.java

160 lines changed: 106 ins; 53 del; 1 mod; 1372 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ModuleFinderTest.java

6 lines changed: 4 ins; 0 del; 2 mod; 798 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ModuleReader/ModuleReaderTest.java

48 lines changed: 32 ins; 9 del; 7 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Layer/BasicLayerTest.java

271 lines changed: 259 ins; 3 del; 9 mod; 951 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/reflect/Module/allow.policy

3 lines changed: 1 ins; 0 del; 2 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/ServiceLoader/basic/basic.sh

3 lines changed: 3 ins; 0 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/internal/jrtfs/java.policy

1 line changed: 0 ins; 0 del; 1 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/net/www/protocol/jrt/java.policy

1 line changed: 0 ins; 0 del; 1 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/krb5/auto/HttpNegotiateServer.java

1 line changed: 1 ins; 0 del; 0 mod; 539 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/IntegrationTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/JLinkNegativeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/CompiledVersionTest.java

4 lines changed: 4 ins; 0 del; 0 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/SystemModulesTest.java

28 lines changed: 8 ins; 5 del; 15 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/UserModuleTest.java

28 lines changed: 18 ins; 1 del; 9 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/src/m1/p1/Main.java

46 lines changed: 33 ins; 1 del; 12 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/plugins/SystemModuleDescriptors/src/m4/p4/Main.java

58 lines changed: 40 ins; 11 del; 7 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/modules/addexports/AddExportsTestWarningError.java

4 lines changed: 0 ins; 0 del; 4 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/modules/addreads/AddReadsTestWarningError.java

4 lines changed: 0 ins; 0 del; 4 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/modules/patch/basic/PatchTestWarningError.java

1 line changed: 0 ins; 0 del; 1 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java

1 line changed: 0 ins; 1 del; 0 mod; 1869 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/module/IllegalAccessLogger.java

318 lines changed: 318 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleTarget.java

46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/Resources.java (was src/java.base/share/classes/jdk/internal/loader/ResourceHelper.java)

75 lines changed: 43 ins; 1 del; 31 mod; 93 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/ClassLoader/getResource/automaticmodules/Driver.java

88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/ClassLoader/getResource/automaticmodules/Main.java

94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/invoke/DefineClassTest.java

352 lines changed: 352 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/module/ModuleFinderWithSecurityManager.java

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/module/java.policy

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/testlibrary/ModuleTargetHelper.java

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/launcher/modules/basic/InitErrors.java

116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/launcher/modules/permit/AttemptAccess.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/launcher/modules/permit/PermitIllegalAccess.java

208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/jenkins/tools/webrev.ksh (vers 25.14-hg+openjdk.java.net).