Code Review for hotspot

Prepared by:andrew on Thu Aug 13 14:44:11 BST 2020
Workspace:/home/ahughes/projects/openjdk/upstream/shenandoah.8/hotspot
Compare against: ssh://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot
Compare against version:aarch64-shenandoah-jdk8u272-b01
Summary of changes: 634 lines changed: 502 ins; 65 del; 67 mod; 51607 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .hgtags

rev 11942 : Added tag jdk8u272-b01 for changeset 85c9d74850ed
rev 11951 : Added tag jdk8u272-b02 for changeset 414c1dcfc3f3
rev 11952 : Merge jdk8u272-b02
rev 11953 : Added tag aarch64-shenandoah-jdk8u272-b02 for changeset 21931e4cd1dc
4 lines changed: 4 ins; 0 del; 0 mod; 1495 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw THIRD_PARTY_README

rev 11943 : 8046274: Removing dependency on jakarta-regexp
Reviewed-by: lancea
rev 11952 : Merge jdk8u272-b02
1 line changed: 0 ins; 1 del; 0 mod; 3243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/aarch64.ad

14 lines changed: 8 ins; 0 del; 6 mod; 15808 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/aarch64_ad.m4

9 lines changed: 4 ins; 0 del; 5 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/templateInterpreter_aarch64.cpp

25 lines changed: 12 ins; 13 del; 0 mod; 2054 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/classFileParser.cpp

rev 11948 : 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent
Summary: Added default format checking of class names loaded by the app class loader
Reviewed-by: andrew
rev 11952 : Merge jdk8u272-b02
11 lines changed: 10 ins; 0 del; 1 mod; 5298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.cpp

rev 11949 : 8048933: -XX:+TraceExceptions output should include the message
Summary: Add the exception detail message to the tracing output
Reviewed-by: minqi, dholmes
rev 11952 : Merge jdk8u272-b02
10 lines changed: 10 ins; 0 del; 0 mod; 3663 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.hpp

rev 11949 : 8048933: -XX:+TraceExceptions output should include the message
Summary: Add the exception detail message to the tracing output
Reviewed-by: minqi, dholmes
rev 11952 : Merge jdk8u272-b02
1 line changed: 1 ins; 0 del; 0 mod; 1470 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/resolutionErrors.cpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
17 lines changed: 10 ins; 1 del; 6 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/resolutionErrors.hpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
10 lines changed: 5 ins; 1 del; 4 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.cpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
rev 11952 : Merge jdk8u272-b02
16 lines changed: 9 ins; 0 del; 7 mod; 2928 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/systemDictionary.hpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
rev 11952 : Merge jdk8u272-b02
5 lines changed: 2 ins; 0 del; 3 mod; 711 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/verifier.cpp

rev 11948 : 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent
Summary: Added default format checking of class names loaded by the app class loader
Reviewed-by: andrew
rev 11952 : Merge jdk8u272-b02
1 line changed: 0 ins; 0 del; 1 mod; 3012 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/verifier.hpp

rev 11948 : 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent
Summary: Added default format checking of class names loaded by the app class loader
Reviewed-by: andrew
3 lines changed: 0 ins; 0 del; 3 mod; 460 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/interpreterRuntime.cpp

rev 11949 : 8048933: -XX:+TraceExceptions output should include the message
Summary: Add the exception detail message to the tracing output
Reviewed-by: minqi, dholmes
rev 11952 : Merge jdk8u272-b02
12 lines changed: 10 ins; 1 del; 1 mod; 1330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/periodic/sampling/jfrCallTrace.cpp

rev 11946 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun, neugens, andrew
3 lines changed: 1 ins; 0 del; 2 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/service/jfrOptionSet.cpp

rev 11946 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun, neugens, andrew
6 lines changed: 1 ins; 4 del; 1 mod; 724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp

rev 11946 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun, neugens, andrew
2 lines changed: 0 ins; 0 del; 2 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/utilities/jfrTypes.hpp

rev 11946 : 8219566: JFR did not collect call stacks when MaxJavaStackTraceDepth is set to zero
Reviewed-by: egahlin, mgronlun, neugens, andrew
3 lines changed: 3 ins; 0 del; 0 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/threadLocalAllocBuffer.cpp

rev 11944 : 8231779: crash HeapWord*ParallelScavengeHeap::failed_mem_allocate
Reviewed-by: dlong, tschatzl, pliden
rev 11952 : Merge jdk8u272-b02
5 lines changed: 2 ins; 0 del; 3 mod; 432 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/constantPool.cpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
rev 11949 : 8048933: -XX:+TraceExceptions output should include the message
Summary: Add the exception detail message to the tracing output
Reviewed-by: minqi, dholmes
rev 11952 : Merge jdk8u272-b02
109 lines changed: 49 ins; 42 del; 18 mod; 2063 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/constantPool.hpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
rev 11952 : Merge jdk8u272-b02
6 lines changed: 5 ins; 1 del; 0 mod; 993 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/reflection.cpp

rev 11948 : 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent
Summary: Added default format checking of class names loaded by the app class loader
Reviewed-by: andrew
rev 11952 : Merge jdk8u272-b02
1 line changed: 0 ins; 0 del; 1 mod; 1178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/constantTag.cpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
rev 11952 : Merge jdk8u272-b02
14 lines changed: 14 ins; 0 del; 0 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/constantTag.hpp

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
rev 11952 : Merge jdk8u272-b02
2 lines changed: 1 ins; 0 del; 1 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/tiered/NonTieredLevelsTest.java

rev 11947 : 8173300: [TESTBUG]compiler/tiered/NonTieredLevelsTest.java fails with compiler.whitebox.SimpleTestCaseHelper(int) must be compiled
Summary: Corrected available compilation levels for client builds.
Reviewed-by: kvn
2 lines changed: 0 ins; 1 del; 1 mod; 94 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/ClassFile/BadHelloWorld.jcod

rev 11948 : 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent
Summary: Added default format checking of class names loaded by the app class loader
Reviewed-by: andrew
138 lines changed: 138 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/ClassFile/FormatCheckingTest.java

rev 11948 : 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent
Summary: Added default format checking of class names loaded by the app class loader
Reviewed-by: andrew
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/ClassResolutionFail/Property.java

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/ClassResolutionFail/PropertySuper.java

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/ClassResolutionFail/TestClassResolutionFail.java

rev 11945 : 8023697: failed class resolution reports different class name in detail message for the first and subsequent times
Summary: Cache detail message when we cache exception for constant pool resolution.
Reviewed-by: acorn, twisti, jrose
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/runtime/CommandLine/TraceExceptionsTest.java

rev 11949 : 8048933: -XX:+TraceExceptions output should include the message
Summary: Add the exception detail message to the tracing output
Reviewed-by: minqi, dholmes
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ahughes/bin/webrev (vers 25.18-hg+openjdk.java.net).