Code Review for jaxp

Prepared by:joehw on Fri Aug 26 10:24:55 PDT 2016
Workspace:/scratch/w/huizwang/openjdk/9-dev/jaxp
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jaxp
Summary of changes: 1567 lines changed: 1071 ins; 373 del; 123 mod; 17981 unchg
Patch of changes: jaxp.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java

21 lines changed: 13 ins; 5 del; 3 mod; 1014 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java

17 lines changed: 6 ins; 8 del; 3 mod; 315 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java

10 lines changed: 5 ins; 0 del; 5 mod; 1693 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java

5 lines changed: 1 ins; 0 del; 4 mod; 1462 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java

29 lines changed: 14 ins; 6 del; 9 mod; 3175 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties

2 lines changed: 2 ins; 0 del; 0 mod; 305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/EntityResolverWrapper.java

13 lines changed: 6 ins; 1 del; 6 mod; 134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java

7 lines changed: 0 ins; 2 del; 5 mod; 3132 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/xml/internal/stream/StaxEntityResolverWrapper.java

4 lines changed: 1 ins; 0 del; 3 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/catalog/Catalog.java

3 lines changed: 0 ins; 0 del; 3 mod; 153 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/catalog/CatalogManager.java

41 lines changed: 0 ins; 40 del; 1 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/catalog/CatalogResolver.java

201 lines changed: 178 ins; 12 del; 11 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/catalog/CatalogResolverImpl.java

258 lines changed: 255 ins; 0 del; 3 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/catalog/Util.java

7 lines changed: 7 ins; 0 del; 0 mod; 202 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/CatalogReferCircularityTest.java

1 line changed: 0 ins; 1 del; 0 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/DefaultFeaturesTest.java

1 line changed: 0 ins; 1 del; 0 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/DeferFeatureTest.java

1 line changed: 0 ins; 1 del; 0 mod; 88 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/DelegatePublicTest.java

1 line changed: 0 ins; 1 del; 0 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/DelegateSystemTest.java

1 line changed: 0 ins; 1 del; 0 mod; 102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/DelegateUriTest.java

4 lines changed: 1 ins; 2 del; 1 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/GroupTest.java

1 line changed: 0 ins; 1 del; 0 mod; 133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/LoadCatalogTest.java

5 lines changed: 1 ins; 2 del; 2 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/NextCatalogTest.java

3 lines changed: 0 ins; 2 del; 1 mod; 159 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/NormalizationTest.java

3 lines changed: 0 ins; 2 del; 1 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/PreferFeatureTest.java

1 line changed: 0 ins; 1 del; 0 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/PreferTest.java

1 line changed: 0 ins; 1 del; 0 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/PublicFamilyTest.java

1 line changed: 0 ins; 1 del; 0 mod; 72 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/PublicTest.java

1 line changed: 0 ins; 1 del; 0 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/ResolveFeatureTest.java

4 lines changed: 0 ins; 2 del; 2 mod; 130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/RewriteSystemTest.java

1 line changed: 0 ins; 1 del; 0 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/RewriteUriTest.java

6 lines changed: 1 ins; 2 del; 3 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/SpecifyCatalogTest.java

4 lines changed: 0 ins; 2 del; 2 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/SystemFamilyTest.java

1 line changed: 0 ins; 1 del; 0 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/SystemSuffixTest.java

1 line changed: 0 ins; 1 del; 0 mod; 97 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/SystemTest.java

1 line changed: 0 ins; 1 del; 0 mod; 94 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/UriFamilyTest.java

7 lines changed: 1 ins; 2 del; 4 mod; 81 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/UriSuffixTest.java

6 lines changed: 1 ins; 2 del; 3 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/UriTest.java

9 lines changed: 1 ins; 2 del; 6 mod; 99 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/UrnUnwrappingTest.java

1 line changed: 0 ins; 1 del; 0 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/ValidateCatalogTest.java

2 lines changed: 0 ins; 1 del; 1 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/catalogFiles/deferFeature.xml

1 line changed: 0 ins; 0 del; 1 mod; 9 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/catalogFiles/uri.xml

1 line changed: 0 ins; 0 del; 1 mod; 11 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/functional/catalog/catalogFiles/uriFamily.xml

1 line changed: 0 ins; 0 del; 1 mod; 14 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/isolatedjdk/catalog/PropertiesTest.java

3 lines changed: 0 ins; 1 del; 2 mod; 119 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/libs/catalog/CatalogTestUtils.java

6 lines changed: 0 ins; 1 del; 5 mod; 174 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/libs/catalog/ResolutionChecker.java

8 lines changed: 0 ins; 1 del; 7 mod; 191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport.java

1 line changed: 0 ins; 1 del; 0 mod; 329 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport.xml

11 lines changed: 0 ins; 0 del; 11 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport1.java

1 line changed: 0 ins; 1 del; 0 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport2.java

1 line changed: 0 ins; 1 del; 0 mod; 272 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport3.java

1 line changed: 0 ins; 1 del; 0 mod; 282 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport4.java

1 line changed: 0 ins; 1 del; 0 mod; 271 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupportBase.java

27 lines changed: 24 ins; 3 del; 0 mod; 935 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogTest.java

237 lines changed: 222 ins; 3 del; 12 mod; 559 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/catalog.xml

0 lines changed: 0 ins; 0 del; 0 mod; 28 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/files/delegatecatalog.xml

0 lines changed: 0 ins; 0 del; 0 mod; 24 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/javax/xml/jaxp/unittest/catalog/system.xml

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport5.java

250 lines changed: 250 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/CatalogSupport_uri.xml

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/catalog_uri.xml

24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/delegateuri.xml

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/files/delegatecatalog_uri.xml

7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/javax/xml/jaxp/unittest/catalog/files/delegateuri.dtd

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/java.xml/share/classes/javax/xml/catalog/CatalogUriResolver.java

58 lines changed: 0 ins; 58 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/java.xml/share/classes/javax/xml/catalog/CatalogUriResolverImpl.java

191 lines changed: 0 ins; 191 del; 0 mod; 0 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).