Code Review for jdk11u-dev

Prepared by:vkempik vkempik on Fri Apr 16 14:20:19 MSK 2021
Workspace:/Users/vkempik/ws/openjdk/jdk11u-dev
Compare against: ssh://hg.openjdk.java.net/jdk-updates/jdk11u-dev
Compare against version:54092
Summary of changes: 3722 lines changed: 1629 ins; 620 del; 1473 mod; 32223 unchg
Changeset: jdk11u-dev.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/common/TestFilesCompilation.gmk

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
1 line changed: 0 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Awt2dLibraries.gmk

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
5 lines changed: 0 ins; 4 del; 1 mod; 1053 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Lib-java.base.gmk

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
3 lines changed: 1 ins; 1 del; 1 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Lib-java.desktop.gmk

rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
5 lines changed: 3 ins; 2 del; 0 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Lib-java.security.jgss.gmk

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
3 lines changed: 0 ins; 0 del; 3 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/lib/Lib-jdk.hotspot.agent.gmk

rev 54099 : 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
Reviewed-by: yan
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/test/JtregNativeJdk.gmk

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
7 lines changed: 3 ins; 1 del; 3 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/macosx/classes/apple/security/KeychainStore.java

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
3 lines changed: 0 ins; 0 del; 3 mod; 1153 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
129 lines changed: 49 ins; 28 del; 52 mod; 548 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTEvent.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
10 lines changed: 0 ins; 1 del; 9 mod; 778 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTSurfaceLayers.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
6 lines changed: 1 ins; 1 del; 4 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
139 lines changed: 50 ins; 21 del; 68 mod; 1436 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.h

rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
4 lines changed: 0 ins; 1 del; 3 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
180 lines changed: 52 ins; 10 del; 118 mod; 1515 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
83 lines changed: 27 ins; 3 del; 53 mod; 770 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CClipboard.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
27 lines changed: 4 ins; 4 del; 19 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CCursorManager.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
14 lines changed: 2 ins; 1 del; 11 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CDataTransferer.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
13 lines changed: 0 ins; 3 del; 10 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CDesktopPeer.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
8 lines changed: 1 ins; 1 del; 6 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CDragSource.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
58 lines changed: 26 ins; 1 del; 31 mod; 701 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CDragSourceContextPeer.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
13 lines changed: 0 ins; 0 del; 13 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CDropTarget.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
46 lines changed: 20 ins; 1 del; 25 mod; 709 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CDropTargetContextPeer.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
21 lines changed: 9 ins; 2 del; 10 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CFRetainedResource.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
7 lines changed: 3 ins; 1 del; 3 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CFileDialog.h

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
1 line changed: 0 ins; 1 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CFileDialog.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
20 lines changed: 3 ins; 2 del; 15 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
23 lines changed: 1 ins; 1 del; 21 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsEnv.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
42 lines changed: 1 ins; 11 del; 30 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CImage.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
32 lines changed: 0 ins; 1 del; 31 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CInputMethod.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
46 lines changed: 12 ins; 10 del; 24 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CMenu.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
15 lines changed: 1 ins; 1 del; 13 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CMenuBar.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
11 lines changed: 2 ins; 1 del; 8 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CMenuComponent.m

rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
2 lines changed: 0 ins; 1 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CMenuItem.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
27 lines changed: 2 ins; 1 del; 24 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CPopupMenu.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
6 lines changed: 0 ins; 1 del; 5 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
rev 54100 : 8259232: Bad JNI lookup during printing
Reviewed-by: psadhukhan
179 lines changed: 73 ins; 1 del; 105 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
6 lines changed: 0 ins; 1 del; 5 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CSystemColors.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
11 lines changed: 5 ins; 3 del; 3 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CTextPipe.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
41 lines changed: 13 ins; 2 del; 26 mod; 675 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CTrayIcon.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
27 lines changed: 2 ins; 1 del; 24 mod; 411 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CWrapper.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
58 lines changed: 1 ins; 0 del; 57 mod; 542 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/GeomUtilities.h

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
2 lines changed: 0 ins; 1 del; 1 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/GeomUtilities.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
63 lines changed: 23 ins; 22 del; 18 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/ImageSurfaceData.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
52 lines changed: 22 ins; 7 del; 23 mod; 1970 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/JavaAccessibilityAction.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
rev 54101 : 8259585: Accessible actions do not work on mac os x
Reviewed-by: serb
40 lines changed: 22 ins; 4 del; 14 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/JavaAccessibilityUtilities.h

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
13 lines changed: 0 ins; 8 del; 5 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/JavaAccessibilityUtilities.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
115 lines changed: 62 ins; 13 del; 40 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
rev 54102 : 8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code
Reviewed-by: serb, psadhukhan
rev 54103 : 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X
Reviewed-by: azvegint, prr
278 lines changed: 164 ins; 26 del; 88 mod; 1757 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/JavaTextAccessibility.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
133 lines changed: 92 ins; 4 del; 37 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/LWCToolkit.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
42 lines changed: 5 ins; 0 del; 37 mod; 819 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/PrintModel.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
11 lines changed: 2 ins; 2 del; 7 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/PrinterSurfaceData.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
4 lines changed: 0 ins; 2 del; 2 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/PrinterView.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
60 lines changed: 24 ins; 7 del; 29 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzRenderer.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
17 lines changed: 0 ins; 1 del; 16 mod; 784 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzSurfaceData.h

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
8 lines changed: 1 ins; 5 del; 2 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/QuartzSurfaceData.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
11 lines changed: 6 ins; 2 del; 3 mod; 1284 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/awt/awt_DrawingSurface.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
28 lines changed: 4 ins; 1 del; 23 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
111 lines changed: 6 ins; 70 del; 35 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/font/AWTStrike.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
33 lines changed: 6 ins; 2 del; 25 mod; 426 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/font/CCharToGlyphMapper.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
5 lines changed: 0 ins; 0 del; 5 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/font/CGGlyphImages.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
2 lines changed: 1 ins; 1 del; 0 mod; 889 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLGraphicsConfig.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
4 lines changed: 1 ins; 1 del; 2 mod; 435 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLLayer.h

rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
5 lines changed: 0 ins; 2 del; 3 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLLayer.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
14 lines changed: 4 ins; 0 del; 10 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/opengl/CGLSurfaceData.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
18 lines changed: 0 ins; 0 del; 18 mod; 435 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosx/CFileManager.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
43 lines changed: 1 ins; 2 del; 40 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.h

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
7 lines changed: 0 ins; 6 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
6 lines changed: 0 ins; 3 del; 3 mod; 484 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxapp/PropertiesUtilities.h

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
4 lines changed: 3 ins; 1 del; 0 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxapp/PropertiesUtilities.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
8 lines changed: 3 ins; 0 del; 5 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxapp/ThreadUtilities.h

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
5 lines changed: 3 ins; 1 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxapp/ThreadUtilities.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
41 lines changed: 38 ins; 1 del; 2 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/AquaFileView.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
18 lines changed: 0 ins; 1 del; 17 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/AquaLookAndFeel.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
3 lines changed: 0 ins; 3 del; 0 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/AquaNativeResources.m

rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
3 lines changed: 0 ins; 1 del; 2 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/JRSUIConstantSync.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
1 line changed: 0 ins; 0 del; 1 mod; 385 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/JRSUIController.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
1 line changed: 0 ins; 0 del; 1 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/JRSUIFocus.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/ScreenMenu.h

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
1 line changed: 0 ins; 1 del; 0 mod; 27 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libosxui/ScreenMenu.m

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54097 : 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
63 lines changed: 25 ins; 2 del; 36 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
7 lines changed: 0 ins; 1 del; 6 mod; 466 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.security.jgss/macosx/native/libosxkrb5/SCDynamicStoreConfig.m

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
239 lines changed: 77 ins; 127 del; 35 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.security.jgss/share/classes/sun/security/krb5/SCDynamicStoreConfig.java

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
119 lines changed: 40 ins; 58 del; 21 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.hotspot.agent/macosx/native/libsaproc/MacosxDebuggerLocal.m

rev 54099 : 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
Reviewed-by: yan
44 lines changed: 35 ins; 2 del; 7 mod; 1059 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/java/awt/print/bug8023392/bug8023392.java

rev 54100 : 8259232: Bad JNI lookup during printing
Reviewed-by: psadhukhan
1 line changed: 0 ins; 0 del; 1 mod; 283 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libosxapp/JNIUtilities.h

rev 54094 : 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
rev 54095 : 8259343: [macOS] Update JNI error handling in Cocoa code.
rev 54096 : 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
250 lines changed: 250 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.desktop/macosx/native/libosxapp/JNIUtilities.m

rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/java/awt/Window/MainKeyWindowTest/libTestMainKeyWindow.m (was test/jdk/java/awt/Window/MainKeyWindowTest/libTestMainKeyWindow.c)

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
rev 54098 : 8260616: Removing remaining JNF dependencies in the java.desktop module
8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
44 lines changed: 34 ins; 0 del; 10 mod; 113 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/sun/security/krb5/config/native/TestDynamicStore.java

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/sun/security/krb5/config/native/libTestDynamicStore.m

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/jdk/sun/security/krb5/config/SCDynamicConfigTest.java

rev 54093 : 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
8257860: [macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m
103 lines changed: 0 ins; 103 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev.ksh (vers 25.17-hg+openjdk.java.net).