Code Review for hs25.40-b18-jdk8u40-b14

Prepared by:amurillo on Fri Nov 7 09:47:44 PST 2014
Workspace:hs25.40-b18-jdk8u40-b14/hotspot
Compare against: jdk8u/jdk8u/hotspot
Compare against version:6856
Summary of changes: 2049 lines changed: 1903 ins; 67 del; 79 mod; 70799 unchg
Changeset: hotspot.changeset
Author comments:
8046268: compiler/whitebox/ tests fail : must be osr_compiled
8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
8057043: Type annotations not retained during class redefine / retransform
8058715: stability issues when being launched as an embedded JVM via JNI
8059216: Make PrintGCApplicationStoppedTime print information about stopping threads
8059780: SPECjvm2008-MPEG performance regressions on x64 platforms
8060454: [TESTBUG] Whitebox tests fail with -XX:CompileThreshold=100
8061486: [TESTBUG] compiler/whitebox/ tests fail : must be osr_compiled (reappeared in nightlies)
8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method
8061983: [TESTBUG] compiler/whitebox/MakeMethodNotCompilableTest.java fails with "must not be in queue"
8062169: Multiple OSR compilations issued for same bci
8062589: new hotspot build - hs25.40-b18
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw .hgtags

rev 6877 : Added tag hs25.40-b18 for changeset 4d5dc0d0f879
2 lines changed: 2 ins; 0 del; 0 mod; 552 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/bsd/makefiles/mapfile-vers-debug

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
3 lines changed: 3 ins; 0 del; 0 mod; 263 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/bsd/makefiles/mapfile-vers-product

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
3 lines changed: 3 ins; 0 del; 0 mod; 258 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/hotspot_version

rev 6859 : 8062589: new hotspot build - hs25.40-b18
Reviewed-by: jcoomes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/linux/makefiles/mapfile-vers-debug

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
3 lines changed: 3 ins; 0 del; 0 mod; 275 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/linux/makefiles/mapfile-vers-product

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
3 lines changed: 3 ins; 0 del; 0 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/solaris/makefiles/mapfile-vers

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
3 lines changed: 3 ins; 0 del; 0 mod; 266 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/os_cpu/linux_x86/vm/os_linux_x86.cpp

rev 6871 : 8058715: stability issues when being launched as an embedded JVM via JNI
Summary: Use mmap call without MAP_FIXED so we avoid corrupting already allocated memory
Reviewed-by: coleenp, dsimms
1 line changed: 0 ins; 0 del; 1 mod; 927 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/classLoader.cpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
8 lines changed: 6 ins; 0 del; 2 mod; 1708 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/classLoader.hpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
7 lines changed: 5 ins; 1 del; 1 mod; 439 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/classLoaderData.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
42 lines changed: 33 ins; 8 del; 1 mod; 953 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/classLoaderData.hpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
4 lines changed: 3 ins; 0 del; 1 mod; 330 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/classLoaderExt.hpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
9 lines changed: 9 ins; 0 del; 0 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/metadataOnStackMark.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
94 lines changed: 81 ins; 5 del; 8 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/metadataOnStackMark.hpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
16 lines changed: 13 ins; 0 del; 3 mod; 42 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/systemDictionary.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
2 lines changed: 0 ins; 0 del; 2 mod; 2851 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/systemDictionary.hpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
3 lines changed: 2 ins; 0 del; 1 mod; 713 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/classfile/vmSymbols.hpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
1 line changed: 1 ins; 0 del; 0 mod; 1278 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/code/nmethod.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
87 lines changed: 70 ins; 11 del; 6 mod; 3220 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/code/nmethod.hpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
7 lines changed: 7 ins; 0 del; 0 mod; 801 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/concurrentMark.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
12 lines changed: 11 ins; 0 del; 1 mod; 4817 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
20 lines changed: 20 ins; 0 del; 0 mod; 7016 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/metadataFactory.hpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
6 lines changed: 6 ins; 0 del; 0 mod; 101 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/metaspaceShared.cpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
8 lines changed: 8 ins; 0 del; 0 mod; 1139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/metaspaceShared.hpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
3 lines changed: 0 ins; 0 del; 3 mod; 134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/constantPool.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
14 lines changed: 12 ins; 1 del; 1 mod; 2102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/instanceKlass.cpp

rev 6867 : 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method
Summary: Fixed Whitebox.deoptimizeMethod() to deoptimize all OSR versions of the method.
Reviewed-by: kvn, iignatyev
16 lines changed: 16 ins; 0 del; 0 mod; 3804 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/instanceKlass.hpp

rev 6867 : 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method
Summary: Fixed Whitebox.deoptimizeMethod() to deoptimize all OSR versions of the method.
Reviewed-by: kvn, iignatyev
1 line changed: 1 ins; 0 del; 0 mod; 1347 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/method.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
6 lines changed: 4 ins; 1 del; 1 mod; 2030 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/oops/method.hpp

rev 6867 : 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method
Summary: Fixed Whitebox.deoptimizeMethod() to deoptimize all OSR versions of the method.
Reviewed-by: kvn, iignatyev
4 lines changed: 4 ins; 0 del; 0 mod; 1069 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/lcm.cpp

rev 6874 : 8059780: SPECjvm2008-MPEG performance regressions on x64 platforms
Summary: Back-out 8052081 changes made in lcm.cpp.
Reviewed-by: iveresov, roland
6 lines changed: 0 ins; 4 del; 2 mod; 1159 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jni.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
2 lines changed: 2 ins; 0 del; 0 mod; 5646 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvm.cpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
39 lines changed: 39 ins; 0 del; 0 mod; 4501 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvm.h

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
25 lines changed: 25 ins; 0 del; 0 mod; 1681 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiClassFileReconstituter.cpp

rev 6869 : 8057043: Type annotations not retained during class redefine / retransform
Reviewed-by: coleenp, sspitsyn, jfranck
22 lines changed: 22 ins; 0 del; 0 mod; 889 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiRedefineClasses.cpp

rev 6869 : 8057043: Type annotations not retained during class redefine / retransform
Reviewed-by: coleenp, sspitsyn, jfranck
rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
623 lines changed: 605 ins; 17 del; 1 mod; 3640 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiRedefineClasses.hpp

rev 6869 : 8057043: Type annotations not retained during class redefine / retransform
Reviewed-by: coleenp, sspitsyn, jfranck
17 lines changed: 17 ins; 0 del; 0 mod; 525 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/whitebox.cpp

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
rev 6867 : 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method
Summary: Fixed Whitebox.deoptimizeMethod() to deoptimize all OSR versions of the method.
Reviewed-by: kvn, iignatyev
39 lines changed: 27 ins; 9 del; 3 mod; 1032 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/arguments.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4146 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/simpleThresholdPolicy.cpp

rev 6865 : 8062169: Multiple OSR compilations issued for same bci
Summary: Fixed 'SimpleThresholdPolicy::event' to always perform OSR if an OSR nmethod is available.
Reviewed-by: kvn, iveresov
9 lines changed: 3 ins; 2 del; 4 mod; 408 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
2 lines changed: 2 ins; 0 del; 0 mod; 4675 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.hpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
14 lines changed: 11 ins; 2 del; 1 mod; 1989 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/runtimeService.cpp

rev 6868 : 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads
Reviewed-by: dholmes, brutisso
9 lines changed: 7 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/runtimeService.hpp

rev 6868 : 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads
Reviewed-by: dholmes, brutisso
1 line changed: 1 ins; 0 del; 0 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/accessFlags.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
15 lines changed: 15 ins; 0 del; 0 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/accessFlags.hpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
4 lines changed: 2 ins; 0 del; 2 mod; 259 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/compiler/whitebox/CompilerWhiteBoxTest.java

rev 6860 : 8046268: compiler/whitebox/ tests fail : must be osr_compiled
Summary: Added code to 'warm up' the methods before triggering OSR compilation by executing them a limited number of times. Like this, the profile information marks the loop exit as taken and we don't add an uncommon trap.
Reviewed-by: kvn, dlong, iignatyev
rev 6861 : 8060454: [TESTBUG] Whitebox tests fail with -XX:CompileThreshold=100
Summary: Move the call to 'waitAndDeoptimize' from the warmup methods to the osr triggering methods to make sure that no non-osr compilation is in the queue after warmup.
Reviewed-by: kvn
rev 6862 : 8061486: [TESTBUG] compiler/whitebox/ tests fail : must be osr_compiled (reappeared in nightlies)
Summary: Call warmup code from OSR triggering method to make sure no non-OSR compilation is triggered in the loop.
Reviewed-by: kvn
rev 6863 : 8061983: [TESTBUG] compiler/whitebox/MakeMethodNotCompilableTest.java fails with "must not be in queue"
Summary: Added a method checkNotCompiled(boolean isOsr) to either check if the method is OSR compiled or to check if it is non-OSR compiled.
Reviewed-by: kvn
127 lines changed: 94 ins; 6 del; 27 mod; 573 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/compiler/whitebox/MakeMethodNotCompilableTest.java

rev 6860 : 8046268: compiler/whitebox/ tests fail : must be osr_compiled
Summary: Added code to 'warm up' the methods before triggering OSR compilation by executing them a limited number of times. Like this, the profile information marks the loop exit as taken and we don't add an uncommon trap.
Reviewed-by: kvn, dlong, iignatyev
rev 6863 : 8061983: [TESTBUG] compiler/whitebox/MakeMethodNotCompilableTest.java fails with "must not be in queue"
Summary: Added a method checkNotCompiled(boolean isOsr) to either check if the method is OSR compiled or to check if it is non-OSR compiled.
Reviewed-by: kvn
4 lines changed: 1 ins; 0 del; 3 mod; 220 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

rev 6864 : 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time
Summary: Implemented the interface in sun.misc.URLClassPath and corresponding JVM_XXX APIs
Reviewed-by: mchung, acorn, jiangli, dholmes
6 lines changed: 6 ins; 0 del; 0 mod; 205 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/share/vm/utilities/chunkedList.cpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/share/vm/utilities/chunkedList.hpp

rev 6875 : 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse
Reviewed-by: mgerdin, coleenp, bdelsart
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/compiler/whitebox/DeoptimizeMultipleOSRTest.java

rev 6867 : 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method
Summary: Fixed Whitebox.deoptimizeMethod() to deoptimize all OSR versions of the method.
Reviewed-by: kvn, iignatyev
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/runtime/RedefineTests/RedefineAnnotations.java

rev 6869 : 8057043: Type annotations not retained during class redefine / retransform
Reviewed-by: coleenp, sspitsyn, jfranck
410 lines changed: 410 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/jcoomes/bin/webrev (vers 25.6-hg+openjdk.java.net).