Code Review for 6953576

Prepared by:never on Tue May 18 14:06:12 PDT 2010
Workspace:/net/smite.sfbay/export/ws/baseline
Compare against: ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot
Compare against version:1435
Summary of changes: 88 lines changed: 2 ins; 71 del; 15 mod; 12613 unchg
Patch of changes: 6953576.patch
Author comments:
6953576: bottom_type for matched AddPNodes doesn't always agree with ideal
Summary:
Reviewed-by:

6715633 added an assert to make sure that the adr_type of nodes
doesn't change during matching. If the address pieces are matched
separately this assert can fail because the logic in
AddPNode::mach_bottom_type isn't the equivalent to
AddPNode::bottom_type. The fix is to simply capture the bottom_type
when transforming the nodes by making AddP matches inherit from
MachTypeNode. This was originally discovered in the ia64 port but I
reproduced it by disabling the use of complex addressing modes to
force the matching AddPs separately.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/addnode.hpp

1 line changed: 0 ins; 1 del; 0 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/addnode.cpp

65 lines changed: 0 ins; 65 del; 0 mod; 914 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/adlc/formssel.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 1061 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/adlc/formssel.cpp

5 lines changed: 2 ins; 0 del; 3 mod; 4059 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/adlc/output_c.cpp

6 lines changed: 0 ins; 0 del; 6 mod; 4145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/adlc/output_h.cpp

8 lines changed: 0 ins; 5 del; 3 mod; 2191 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).