Code Review for open

Prepared by:rriggs on Wed May 15 13:58:23 EDT 2019
Workspace:/ws/valhalla-dev/open
Compare against version:-2
Branch:lworld
Summary of changes: 592 lines changed: 151 ins; 61 del; 380 mod; 74113 unchg
Patch of changes: open.patch
Bug id: JDK-8223351] [lworld : Primary mirror and nullable mirror for inline type
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciInstance.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciMethodType.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 0 del; 2 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciValueKlass.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
3 lines changed: 0 ins; 0 del; 3 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciValueKlass.hpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
54 lines changed: 3 ins; 6 del; 45 mod; 4483 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.hpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
10 lines changed: 0 ins; 0 del; 10 mod; 1570 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 0 del; 2 mod; 1077 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
4 lines changed: 0 ins; 0 del; 4 mod; 1680 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/valueKlass.hpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
4 lines changed: 1 ins; 0 del; 3 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2compiler.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 0 del; 2 mod; 641 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/graphKit.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
7 lines changed: 0 ins; 0 del; 7 mod; 4430 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
11 lines changed: 0 ins; 0 del; 11 mod; 7149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 4978 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jni.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
10 lines changed: 9 ins; 0 del; 1 mod; 4348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/methodHandles.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 1616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/reflection.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
7 lines changed: 2 ins; 0 del; 5 mod; 1281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/signature.cpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
7 lines changed: 6 ins; 0 del; 1 mod; 601 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/accessFlags.hpp

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
3 lines changed: 1 ins; 0 del; 2 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Class.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
75 lines changed: 15 ins; 14 del; 46 mod; 4152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
10 lines changed: 0 ins; 2 del; 8 mod; 961 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/LambdaFormBuilder.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 624 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MemberName.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
15 lines changed: 9 ins; 0 del; 6 mod; 1200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 1 del; 1 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandles.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 0 del; 2 mod; 6091 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/ValueBootstrapMethods.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
15 lines changed: 6 ins; 0 del; 9 mod; 588 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandle.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 0 del; 2 mod; 2289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandles.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
3 lines changed: 0 ins; 0 del; 3 mod; 584 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/AccessibleObject.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 736 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Constructor.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
4 lines changed: 0 ins; 1 del; 3 mod; 672 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Field.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
4 lines changed: 0 ins; 1 del; 3 mod; 1239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Method.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 1 del; 1 mod; 729 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Modifier.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 1 del; 0 mod; 495 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Proxy.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
3 lines changed: 1 ins; 1 del; 1 mod; 1120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
8 lines changed: 4 ins; 0 del; 4 mod; 2036 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/experimental/value/MethodHandleBuilder.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 0 del; 2 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/Unsafe.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
17 lines changed: 0 ins; 0 del; 17 mod; 4072 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Type.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
38 lines changed: 32 ins; 5 del; 1 mod; 928 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/AccessorGenerator.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
9 lines changed: 6 ins; 0 del; 3 mod; 724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/reflect/UnsafeFieldAccessorImpl.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/BytecodeDescriptor.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
4 lines changed: 1 ins; 0 del; 3 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/invoke/util/VerifyAccess.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
6 lines changed: 4 ins; 0 del; 2 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestIntrinsics.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
61 lines changed: 0 ins; 0 del; 61 mod; 942 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
2 lines changed: 0 ins; 1 del; 1 mod; 2065 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestMethodHandles.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
10 lines changed: 0 ins; 0 del; 10 mod; 483 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNativeClone.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
7 lines changed: 0 ins; 3 del; 4 mod; 1602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
3 lines changed: 0 ins; 0 del; 3 mod; 802 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueOops.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 663 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
5 lines changed: 0 ins; 0 del; 5 mod; 523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/MethodHandleTest.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
15 lines changed: 0 ins; 6 del; 9 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/NonFlattenValue.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
4 lines changed: 1 ins; 1 del; 2 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/ObjectMethods.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
9 lines changed: 0 ins; 1 del; 8 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/QTypeDescriptorTest.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
8 lines changed: 0 ins; 0 del; 8 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/Reflection.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
97 lines changed: 50 ins; 10 del; 37 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/ValueArray.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
3 lines changed: 0 ins; 0 del; 3 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/valhalla/valuetypes/ValueBootstrapMethods.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
10 lines changed: 0 ins; 6 del; 4 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/ValueBootstrapMethodsTest.java

rev 55127 : 8223351: [lworld] Primary mirror and nullable mirror for inline type
Reviewed-by: tbd
1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

This code review page was prepared using /home/rriggs/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).