Code Review for jdk

Prepared by:darcy on Wed Jul 2 23:02:54 PDT 2014
Workspace:/home/darcy/Sun/OpenJDK/9/client/jdk
Compare against: http://hg.openjdk.java.net/jdk9/client/jdk
Summary of changes: 1052 lines changed: 54 ins; 62 del; 936 mod; 63701 unchg
Patch of changes: jdk.patch
Bug id: JDK-8042849 : Fix raw and unchecked warnings in com.sun.java.swing
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java

30 lines changed: 4 ins; 0 del; 26 mod; 1389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/gtk/GTKIconFactory.java

7 lines changed: 0 ins; 0 del; 7 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java

4 lines changed: 0 ins; 0 del; 4 mod; 1137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java

5 lines changed: 0 ins; 0 del; 5 mod; 2154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/gtk/XColors.java

6 lines changed: 0 ins; 2 del; 4 mod; 825 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/motif/MotifComboBoxUI.java

2 lines changed: 0 ins; 0 del; 2 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java

4 lines changed: 0 ins; 0 del; 4 mod; 866 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/windows/DesktopProperty.java

2 lines changed: 0 ins; 0 del; 2 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/windows/TMSchema.java

4 lines changed: 0 ins; 0 del; 4 mod; 561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java

10 lines changed: 0 ins; 0 del; 10 mod; 559 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java

3 lines changed: 0 ins; 0 del; 3 mod; 1327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/windows/XPStyle.java

1 line changed: 0 ins; 0 del; 1 mod; 755 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/JComboBox.java

5 lines changed: 0 ins; 0 del; 5 mod; 2445 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/JSlider.java

21 lines changed: 0 ins; 0 del; 21 mod; 1502 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/ComboBoxUI.java

4 lines changed: 0 ins; 0 del; 4 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/LayerUI.java

10 lines changed: 5 ins; 0 del; 5 mod; 715 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/ListUI.java

4 lines changed: 0 ins; 0 del; 4 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java

1 line changed: 0 ins; 0 del; 1 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java

3 lines changed: 0 ins; 0 del; 3 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java

30 lines changed: 8 ins; 0 del; 22 mod; 1978 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java

19 lines changed: 4 ins; 0 del; 15 mod; 1280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java

2 lines changed: 0 ins; 0 del; 2 mod; 496 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java

6 lines changed: 1 ins; 0 del; 5 mod; 1376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicListUI.java

38 lines changed: 8 ins; 0 del; 30 mod; 2855 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java

1 line changed: 0 ins; 0 del; 1 mod; 2257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java

3 lines changed: 0 ins; 0 del; 3 mod; 628 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java

3 lines changed: 0 ins; 0 del; 3 mod; 1455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java

1 line changed: 0 ins; 0 del; 1 mod; 1621 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java

19 lines changed: 0 ins; 0 del; 19 mod; 2008 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicSpinnerUI.java

1 line changed: 0 ins; 0 del; 1 mod; 1073 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java

9 lines changed: 0 ins; 0 del; 9 mod; 952 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicTableUI.java

6 lines changed: 0 ins; 0 del; 6 mod; 2212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java

2 lines changed: 0 ins; 0 del; 2 mod; 4595 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/ComboPopup.java

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/basic/LazyActionMap.java

4 lines changed: 0 ins; 0 del; 4 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/metal/MetalBumps.java

2 lines changed: 1 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/metal/MetalComboBoxButton.java

9 lines changed: 0 ins; 0 del; 9 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java

1 line changed: 0 ins; 0 del; 1 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java

8 lines changed: 0 ins; 0 del; 8 mod; 1387 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/metal/MetalToolBarUI.java

2 lines changed: 0 ins; 0 del; 2 mod; 416 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/metal/MetalUtils.java

6 lines changed: 2 ins; 0 del; 4 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/metal/OceanTheme.java

2 lines changed: 0 ins; 0 del; 2 mod; 458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiButtonUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiColorChooserUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiComboBoxUI.java

24 lines changed: 0 ins; 2 del; 22 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiDesktopIconUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiDesktopPaneUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiFileChooserUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiInternalFrameUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiLabelUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiListUI.java

24 lines changed: 0 ins; 2 del; 22 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiLookAndFeel.java

4 lines changed: 0 ins; 0 del; 4 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiMenuBarUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiMenuItemUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiOptionPaneUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiPanelUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiPopupMenuUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiProgressBarUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiRootPaneUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiScrollBarUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiScrollPaneUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiSeparatorUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiSliderUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiSpinnerUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiSplitPaneUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiTabbedPaneUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiTableHeaderUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiTableUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiTextUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiToolBarUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiToolTipUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiTreeUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 335 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/multi/MultiViewportUI.java

21 lines changed: 0 ins; 2 del; 19 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/nimbus/NimbusIcon.java

11 lines changed: 6 ins; 0 del; 5 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/nimbus/NimbusStyle.java

38 lines changed: 9 ins; 0 del; 29 mod; 1089 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/nimbus/State.java

8 lines changed: 0 ins; 0 del; 8 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/nimbus/SynthPainterImpl.java

6 lines changed: 1 ins; 0 del; 5 mod; 2797 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/nimbus/TableScrollPaneCorner.java

2 lines changed: 1 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/DefaultSynthStyleFactory.java

12 lines changed: 0 ins; 0 del; 12 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/ImagePainter.java

2 lines changed: 1 ins; 0 del; 1 mod; 1019 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/Region.java

3 lines changed: 2 ins; 0 del; 1 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java

6 lines changed: 0 ins; 0 del; 6 mod; 764 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthComboPopup.java

1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthListUI.java

1 line changed: 0 ins; 0 del; 1 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java

1 line changed: 0 ins; 0 del; 1 mod; 984 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthParser.java

5 lines changed: 0 ins; 0 del; 5 mod; 1330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java

7 lines changed: 0 ins; 0 del; 7 mod; 999 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthTableHeaderUI.java

1 line changed: 0 ins; 0 del; 1 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthTableUI.java

2 lines changed: 0 ins; 0 del; 2 mod; 829 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java

1 line changed: 0 ins; 0 del; 1 mod; 821 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/swing/BakedArrayList.java

4 lines changed: 1 ins; 0 del; 3 mod; 91 unchg

This code review page was prepared using /home/darcy/Sun/OpenJDK/webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).