Code Review for open

Prepared by:coleenp on Mon Jun 4 20:53:46 EDT 2018
Workspace:/scratch/cphillim/hg/11order-access/open
Summary of changes: 246 lines changed: 35 ins; 79 del; 132 mod; 104878 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/relocInfo_arm.cpp

1 line changed: 0 ins; 0 del; 1 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/nativeInst_ppc.cpp

1 line changed: 0 ins; 0 del; 1 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/zero/cppInterpreter_zero.cpp

1 line changed: 0 ins; 0 del; 1 mod; 823 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/aix/os_aix.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_bsd.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3929 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.cpp

1 line changed: 0 ins; 0 del; 1 mod; 6158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.cpp

1 line changed: 0 ins; 0 del; 1 mod; 5476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.cpp

1 line changed: 0 ins; 0 del; 1 mod; 5665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/dictionary.cpp

1 line changed: 0 ins; 0 del; 1 mod; 645 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/dictionary.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3055 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verifier.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/nmethod.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2966 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/adaptiveFreeList.cpp

1 line changed: 0 ins; 0 del; 1 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsCardTable.cpp

1 line changed: 0 ins; 0 del; 1 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp

1 line changed: 0 ins; 0 del; 1 mod; 8116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1AllocRegion.cpp

1 line changed: 0 ins; 0 del; 1 mod; 391 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CardTable.cpp

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4973 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/heapRegion.cpp

1 line changed: 0 ins; 0 del; 1 mod; 884 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/gcTaskManager.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1072 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1008 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/space.cpp

1 line changed: 0 ins; 0 del; 1 mod; 731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecodeInterpreter.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3495 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/leakprofiler/leakProfiler.cpp

1 line changed: 0 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp

1 line changed: 0 ins; 0 del; 1 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp

1 line changed: 0 ins; 0 del; 1 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.cpp

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp

1 line changed: 0 ins; 0 del; 1 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp

1 line changed: 0 ins; 0 del; 1 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp

1 line changed: 0 ins; 0 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp

1 line changed: 0 ins; 0 del; 1 mod; 765 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/storage/jfrStorageControl.cpp

1 line changed: 0 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/storage/jfrVirtualMemory.cpp

1 line changed: 0 ins; 0 del; 1 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp

1 line changed: 0 ins; 0 del; 1 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/recorder/stringpool/jfrStringPoolBuffer.cpp

1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/utilities/jfrAllocation.cpp

1 line changed: 0 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/utilities/jfrHashtable.hpp

1 line changed: 0 ins; 0 del; 1 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logOutputList.cpp

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1786 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace/virtualSpaceList.cpp

1 line changed: 0 ins; 0 del; 1 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/array.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/arrayKlass.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/constantPool.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

1 line changed: 0 ins; 0 del; 1 mod; 833 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3747 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 851 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1793 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/precompiled/precompiled.hpp

1 line changed: 0 ins; 0 del; 1 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jni.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3677 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvmtiRawMonitor.cpp

1 line changed: 0 ins; 0 del; 1 mod; 423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/unsafe.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/interfaceSupport.cpp

1 line changed: 0 ins; 0 del; 1 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/mutex.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/objectMonitor.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/orderAccess.hpp

35 lines changed: 35 ins; 0 del; 0 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/perfMemory.cpp

1 line changed: 0 ins; 0 del; 1 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/safepoint.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sweeper.cpp

1 line changed: 0 ins; 0 del; 1 mod; 847 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4970 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memTracker.cpp

1 line changed: 0 ins; 0 del; 1 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryManager.cpp

1 line changed: 0 ins; 0 del; 1 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryPool.cpp

1 line changed: 0 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/concurrentHashTable.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 1215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalCounter.cpp

1 line changed: 0 ins; 0 del; 1 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalCounter.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/hashtable.inline.hpp

1 line changed: 0 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/utilities/test_globalCounter.cpp

1 line changed: 0 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp (was src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.inline.hpp)

3 lines changed: 0 ins; 0 del; 3 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp (was src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.inline.hpp)

9 lines changed: 0 ins; 3 del; 6 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.hpp (was src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.inline.hpp)

3 lines changed: 0 ins; 0 del; 3 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp (was src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.inline.hpp)

4 lines changed: 0 ins; 1 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp (was src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.inline.hpp)

5 lines changed: 0 ins; 0 del; 5 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp (was src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.inline.hpp)

3 lines changed: 0 ins; 0 del; 3 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp (was src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.inline.hpp)

3 lines changed: 0 ins; 0 del; 3 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.hpp (was src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.inline.hpp)

3 lines changed: 0 ins; 0 del; 3 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp (was src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.inline.hpp)

9 lines changed: 0 ins; 3 del; 6 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.hpp (was src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.inline.hpp)

3 lines changed: 0 ins; 0 del; 3 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.hpp (was src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.inline.hpp)

3 lines changed: 0 ins; 0 del; 3 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.hpp (was src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.inline.hpp)

8 lines changed: 0 ins; 3 del; 5 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp (was src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.inline.hpp)

8 lines changed: 0 ins; 3 del; 5 mod; 108 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/runtime/orderAccess.inline.hpp

66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

This code review page was prepared using /home/cphillim/bin/official-webrev/webrev.ksh (vers 25.14-hg+openjdk.java.net).