Code Review for hotspot

Prepared by:andrew on Thu Aug 10 07:36:06 BST 2017
Workspace:/home/andrew/projects/openjdk/upstream/jdk7/hotspot
Compare against: ssh://hg.openjdk.java.net/jdk7u/jdk7u/hotspot
Compare against version:5780
Summary of changes: 1211 lines changed: 1090 ins; 69 del; 52 mod; 95911 unchg
Changeset: hotspot.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw .hgtags

rev 5790 : Added tag jdk7u151-b00 for changeset 75662a7ec171
rev 5792 : Added tag jdk7u151-b01 for changeset d0c7cea0660f
2 lines changed: 2 ins; 0 del; 0 mod; 847 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/linux/makefiles/gcc.make

rev 5782 : 8179887: Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated
Summary: Disable deprecated declarations so the build doesn't fail with -Werror
Reviewed-by: omajid
1 line changed: 1 ins; 0 del; 0 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/ppc/vm/ppc.ad

rev 5788 : 8181420: PPC: Image conversion improvements
Reviewed-by: thartmann, simonis, mbaesken
rev 5791 : 8185716: OpenJDK 7 PPC64 port uses a different ins_encode format in ppc.ad
Summary: Use existing ins_encode format for implementing 8181420
Reviewed-by: omajid
25 lines changed: 25 ins; 0 del; 0 mod; 12869 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/sparc/vm/sparc.ad

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
134 lines changed: 134 ins; 0 del; 0 mod; 10943 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/x86_32.ad

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
rev 5789 : 8185502: No overflow operator on OpenJDK 7
Summary: Remove usage of overflow in x86_32.ad
Reviewed-by: roland, andrew
149 lines changed: 148 ins; 0 del; 1 mod; 13193 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/x86_64.ad

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
42 lines changed: 42 ins; 0 del; 0 mod; 11517 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/adlc/archDesc.cpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
1 line changed: 1 ins; 0 del; 0 mod; 1208 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/c2_globals.hpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
1 line changed: 0 ins; 0 del; 1 mod; 643 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callGenerator.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
10 lines changed: 9 ins; 0 del; 1 mod; 1156 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callGenerator.hpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
0 lines changed: 0 ins; 0 del; 0 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callnode.cpp

rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
1 line changed: 1 ins; 0 del; 0 mod; 1714 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callnode.hpp

rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
rev 5786 : 8174164: SafePointNode::_replaced_nodes breaks with irreducible loops
Reviewed-by: kvn
33 lines changed: 33 ins; 0 del; 0 mod; 991 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/classes.hpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
1 line changed: 1 ins; 0 del; 0 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/compile.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
7 lines changed: 5 ins; 0 del; 2 mod; 3770 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/compile.hpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
3 lines changed: 2 ins; 0 del; 1 mod; 1125 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/doCall.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
0 lines changed: 0 ins; 0 del; 0 mod; 1005 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
36 lines changed: 29 ins; 0 del; 7 mod; 3874 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.hpp

rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
1 line changed: 0 ins; 0 del; 1 mod; 901 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/ifnode.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
1 line changed: 0 ins; 0 del; 1 mod; 1205 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/library_call.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
0 lines changed: 0 ins; 0 del; 0 mod; 5669 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/loopPredicate.cpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
190 lines changed: 100 ins; 61 del; 29 mod; 841 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/loopnode.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
2 lines changed: 0 ins; 0 del; 2 mod; 3800 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/loopnode.hpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
9 lines changed: 0 ins; 7 del; 2 mod; 1117 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/loopopts.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
2 lines changed: 0 ins; 0 del; 2 mod; 2777 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/multnode.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
58 lines changed: 58 ins; 0 del; 0 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/multnode.hpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
8 lines changed: 8 ins; 0 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/node.cpp

rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
6 lines changed: 6 ins; 0 del; 0 mod; 2124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/output.cpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
1 line changed: 1 ins; 0 del; 0 mod; 3034 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/parse.hpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
5 lines changed: 4 ins; 1 del; 0 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/parse1.cpp

rev 5783 : 8024069: replace_in_map() should operate on parent maps
Summary: type information gets lost because replace_in_map() doesn't update parent maps
Reviewed-by: kvn, twisti
rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
rev 5786 : 8174164: SafePointNode::_replaced_nodes breaks with irreducible loops
Reviewed-by: kvn
26 lines changed: 25 ins; 0 del; 1 mod; 2224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/subnode.cpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
54 lines changed: 54 ins; 0 del; 0 mod; 1391 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/subnode.hpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
9 lines changed: 9 ins; 0 del; 0 mod; 561 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/vmStructs.cpp

rev 5781 : 8173770: Image conversion improvements
Reviewed-by: kvn, vlivanov, dlong, rhalade, mschoene, iignatyev
1 line changed: 1 ins; 0 del; 0 mod; 3239 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/growableArray.hpp

rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
2 lines changed: 1 ins; 0 del; 1 mod; 409 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/opto/replacednodes.cpp

rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
rev 5785 : 8048703: ReplacedNodes dumps it's content to tty
Reviewed-by: roland, iveresov, drchase
rev 5786 : 8174164: SafePointNode::_replaced_nodes breaks with irreducible loops
Reviewed-by: kvn
223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/opto/replacednodes.hpp

rev 5784 : 8026796: Make replace_in_map() on parent maps generic
Summary: propagate node replacements along control flow edges to callers
Reviewed-by: kvn, vlivanov
rev 5786 : 8174164: SafePointNode::_replaced_nodes breaks with irreducible loops
Reviewed-by: kvn
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/compiler/c2/TestReplacedNodesOSR.java

rev 5787 : 8175097: [TESTBUG] 8174164 fix missed the test
Reviewed-by: kvn
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/andrew/bin/webrev (vers 25.16-hg+openjdk.java.net).